Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Implementing std::io::Error for impit::ErrorType #84

Open
FjodorGit opened this issue Mar 6, 2025 · 1 comment
Open

Question: Implementing std::io::Error for impit::ErrorType #84

FjodorGit opened this issue Mar 6, 2025 · 1 comment

Comments

@FjodorGit
Copy link

Hi there! 👋

I was wondering if it would be possible (or advisable) to implement std::io::Error for this type to better integrate with Rust’s error handling.
I believe the simplest approach would be to use thiserror, which appears to already be an indirect dependency in the project.

FjodorGit added a commit to FjodorGit/impit that referenced this issue Mar 6, 2025
@barjin
Copy link
Contributor

barjin commented Mar 10, 2025

Hello and thank you for your suggestion! Usage of thiserror indeed seems like something that would give impit better DX.

I'm on PTO for one more week and I have no way of testing this. Putting a bookmark on this, though - I'll check it out once I'm back (likely next week).

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants