Browserpool slices of last char of proxy url

[harm-matthias-harms]

Which package is this bug report for? If unsure which one to select, leave blank

@crawlee/browser-pool

Issue description

We encounter a problem trying to use socks proxies with browser-pool. In particular, we lose the last digit of the port number when slicing the URL.

https://github.com/apify/crawlee/blob/master/packages/browser-pool/src/anonymize-proxy.ts#L19

Here, the last character of the URL is sliced. This is fine for HTTP proxies because they end with /, but socks proxies don't have a trailing slash. From our first test, HTTP proxies with trailing slashes work as expected, and we don't need to slice them.

For http

proxy: http://username:password@proxy:1000
url.href: http://username:password@proxy:1000/
url.href.slice(0, -1): http://username:password@proxy:1000

For socks5

proxy: socks5://username:password@proxy:1000
url.href: socks5://username:password@proxy:1000
url.href.slice(0, -1):  socks5://username:password@proxy:100

Code sample

Package version

latest

Node.js version

lts

Operating system

linux

Apify platform

• Tick me if you encountered this issue on the Apify platform

I have tested this on the next release

No response

Other context

No response

[janbuchar]

Hello, and thanks for your interest in Crawlee. It seems that the issue is missing a code sample that reproduces the issue, could you please add that? Without that, it is difficult for us to troubleshoot this.