Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestQueue locks might get lost in specific scenarios #2849

Open
janbuchar opened this issue Feb 17, 2025 · 0 comments
Open

RequestQueue locks might get lost in specific scenarios #2849

janbuchar opened this issue Feb 17, 2025 · 0 comments
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.
Milestone

Comments

@janbuchar
Copy link
Contributor

Error scenario

  1. fetch and lock 25 requests in RequestQueue, lock time is 60s
  2. each takes 10s, which is within the request handler timeout
  3. after a couple of requests, the "locally dequeued" requests won't be locked anymore

This becomes worse if the user runs a CPU-bound thing that stalls the node.js event loop.

Possible solutions

  1. ignore it
  2. run a background loop that periodically prolongs all held locks
  3. prolong locks in fetchNextRequest - that should be called at least once per requestHandlerTimeout
@janbuchar janbuchar added the bug Something isn't working. label Feb 17, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Feb 17, 2025
@B4nan B4nan added this to the 4.0 milestone Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

2 participants