Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests on Windows #2832

Open
janbuchar opened this issue Feb 7, 2025 · 3 comments
Open

Run unit tests on Windows #2832

janbuchar opened this issue Feb 7, 2025 · 3 comments
Assignees
Labels
debt Code quality improvement or decrease of technical debt. infrastructure Issues related to infrastructure or CI/CD pipeline. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@janbuchar
Copy link
Contributor

@janbuchar janbuchar added debt Code quality improvement or decrease of technical debt. infrastructure Issues related to infrastructure or CI/CD pipeline. t-tooling Issues with this label are in the ownership of the tooling team. labels Feb 7, 2025
@B4nan
Copy link
Member

B4nan commented Feb 7, 2025

I am afraid this will have a pretty negative effect on the CI, windows in CI is terribly slow and flaky, so if we are to do this, I would at least keep the checks optional.

@janbuchar
Copy link
Contributor Author

I mean, we already run tests on windows in crawlee-python. You are right that they are like 50-100% slower than on Linux, but we live with that.

@vladfrangu
Copy link
Member

I thought we still ran tests on windows, just not required for PRs to be merged (as windows has been consistently unstable) 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality improvement or decrease of technical debt. infrastructure Issues related to infrastructure or CI/CD pipeline. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

3 participants