Review comments

Author: Pijukatel

src/crawlee/fingerprint_suite/_browserforge_adapter.py

@@ -136,7 +136,8 @@ def _get_single_browser_type(self, browser: Iterable[str | Browser] | None) -> s
         """
         # In our case we never pass more than one browser type. In general case more browsers are just bigger pool to
         # select from, so narrowing it to any of them is still a valid action as we are going to pick just one anyway.
-
+        if isinstance(browser, str):
+            return browser
         if isinstance(browser, Iterable):
             choice = random.choice(
                 [

tests/unit/crawlers/_playwright/test_playwright_crawler.py

@@ -30,6 +30,7 @@
 )
 from crawlee.fingerprint_suite._browserforge_adapter import get_available_header_values
 from crawlee.fingerprint_suite._consts import BROWSER_TYPE_HEADER_KEYWORD
+from crawlee.fingerprint_suite._header_generator import fingerprint_browser_type_from_playwright_browser_type
 from crawlee.http_clients import HttpxHttpClient
 from crawlee.proxy_configuration import ProxyConfiguration
 from crawlee.sessions import Session, SessionPool
@@ -215,7 +216,10 @@ async def request_handler(context: PlaywrightCrawlingContext) -> None:
 
     user_agent = headers.get('user-agent')
     assert user_agent in get_available_header_values(header_network, {'user-agent', 'User-Agent'}), user_agent
-    assert any(keyword in user_agent for keyword in BROWSER_TYPE_HEADER_KEYWORD['chrome']), user_agent
+    assert any(
+        keyword in user_agent
+        for keyword in BROWSER_TYPE_HEADER_KEYWORD[fingerprint_browser_type_from_playwright_browser_type(browser_type)]
+    ), user_agent
 
     assert headers.get('sec-ch-ua') in get_available_header_values(header_network, 'sec-ch-ua')
     assert headers.get('sec-ch-ua-mobile') in get_available_header_values(header_network, 'sec-ch-ua-mobile')
@@ -249,7 +253,10 @@ async def request_handler(context: PlaywrightCrawlingContext) -> None:
 
     user_agent = headers.get('user-agent')
     assert user_agent in get_available_header_values(header_network, {'user-agent', 'User-Agent'})
-    assert any(keyword in user_agent for keyword in BROWSER_TYPE_HEADER_KEYWORD[browser_type])
+    assert any(
+        keyword in user_agent
+        for keyword in BROWSER_TYPE_HEADER_KEYWORD[fingerprint_browser_type_from_playwright_browser_type(browser_type)]
+    )
 
 
 async def test_custom_headers(server_url: URL) -> None:

tests/unit/fingerprint_suite/test_adapters.py

@@ -1,8 +1,15 @@
+from collections.abc import Iterable
+
+import pytest
+from browserforge.headers import Browser
+
 from crawlee.fingerprint_suite import (
     DefaultFingerprintGenerator,
     HeaderGeneratorOptions,
     ScreenOptions,
 )
+from crawlee.fingerprint_suite._browserforge_adapter import PatchedHeaderGenerator
+from crawlee.fingerprint_suite._consts import BROWSER_TYPE_HEADER_KEYWORD
 
 
 def test_fingerprint_generator_has_default() -> None:
@@ -64,3 +71,17 @@ def test_fingerprint_generator_all_options() -> None:
     assert 'Firefox' in fingerprint.navigator.userAgent
     assert 'Win' in fingerprint.navigator.oscpu
     assert 'en-US' in fingerprint.navigator.languages
+
+
+@pytest.mark.parametrize(
+    'browser',
+    [
+        'firefox',
+        ['firefox'],
+        [Browser(name='firefox')],
+    ],
+)
+def test_patched_header_generator_generate(browser: Iterable[str | Browser]) -> None:
+    """Test that PatchedHeaderGenerator works with all the possible types correctly."""
+    header = PatchedHeaderGenerator().generate(browser=browser)
+    assert any(keyword in header['User-Agent'] for keyword in BROWSER_TYPE_HEADER_KEYWORD['firefox'])