Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(web-scraper): Max result records counts processed pages, not results #353

Open
barjin opened this issue Feb 4, 2025 · 0 comments
Open
Labels
bug Something isn't working.

Comments

@barjin
Copy link
Contributor

barjin commented Feb 4, 2025

As reported in a user issue, returning undefined from the Page Function still fires a request to the Dataset API (adding no item) and counts towards the Max result records (maxResultsPerCrawl) crawler limit.

With the limit set to e.g. 10 and pageFunction returning undefined on every other request, the Actor will finish with 5 dataset items only (will stop prematurely, since the "limit has been hit").

This seems like a bug to me, so I'd fix it regardless of whether it's breaking.

Reproduction scenario here: https://console.apify.com/view/runs/T3XtWRqfhCSFUeH7X

edit: this is likely the case with other generic Actors as well.

@barjin barjin added the bug Something isn't working. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

1 participant