Skip to content

Commit 6074d2e

Browse files
committed
Updated build-args logic
1 parent 2a61d88 commit 6074d2e

File tree

1 file changed

+7
-29
lines changed

1 file changed

+7
-29
lines changed

.github/workflows/ci-eds-notebooks.yaml

Lines changed: 7 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -19,42 +19,20 @@ jobs:
1919
image-name: "ghcr.io/aphp/base-eds-notebook"
2020
image-custom-tag: "x86_64-ubuntu-24.04"
2121
extra-build-args: |
22-
"[
23-
{
24-
'name':'JUPYTER_BASE_NOTEBOOK_IMAGE',
25-
'value':'quay.io/jupyter/base-notebook:x86_64-ubuntu-24.04'
26-
},
27-
{
28-
'name':'NOTEBOOK_IMAGE',
29-
'value':'EDS-BASE-NOTEBOOK'
30-
},
31-
{
32-
'name':'NOTEBOOK_MAINTAINER',
33-
'value':'aphp'
34-
},
35-
]"
22+
JUPYTER_BASE_NOTEBOOK_IMAGE=quay.io/jupyter/base-notebook:x86_64-ubuntu-24.04
23+
NOTEBOOK_IMAGE=EDS-BASE-NOTEBOOK
24+
NOTEBOOK_MAINTAINER=aphp
3625
3726
eds-ocaml-notebook:
3827
uses: "aphp/ci-workflows/.github/workflows/container-ci.yml@dev"
3928
needs: "eds-base-notebook"
40-
if: ${{ needs.eds-base-notebook.result == 'success' }}
29+
if: ${{ needs.eds-base-notebook.result == "success" }}
4130
with:
4231
dockerfile-path: "eds-ocaml-notebook/Dockerfile"
4332
ignore_hadolint_rules: "DL3008,DL3016"
4433
image-name: "ghcr.io/aphp/base-ocaml-notebook"
4534
image-custom-tag: "x86_64-ubuntu-24.04"
4635
extra-build-args: |
47-
"[
48-
{
49-
'name':'EDS_BASE_NOTEBOOK_IMAGE',
50-
'value':'ghcr.io/aphp/base-eds-notebook:x86_64-ubuntu-24.04'
51-
},
52-
{
53-
'name':'NOTEBOOK_IMAGE',
54-
'value':'EDS-BASE-NOTEBOOK'
55-
},
56-
{
57-
'name':'NOTEBOOK_MAINTAINER',
58-
'value':'aphp'
59-
},
60-
]"
36+
EDS_BASE_NOTEBOOK_IMAGE=ghcr.io/aphp/base-eds-notebook:x86_64-ubuntu-24.04
37+
NOTEBOOK_IMAGE=EDS-OCAML-NOTEBOOK
38+
NOTEBOOK_MAINTAINER=aphp

0 commit comments

Comments
 (0)