Skip to content
This repository was archived by the owner on Dec 25, 2023. It is now read-only.

Extension activates but doesn't provide LSP functionality when NodeJS installed by asdf #84

Closed
alex-ketch opened this issue Sep 22, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@alex-ketch
Copy link
Contributor

To reproduce

Steps to reproduce the behavior:

  1. Create a new TypeScript project (just a tsconfig.json and an index.ts)
  2. Write incorrect TS code
  3. Nothing happens… 🦗

This was experience with the extension provided TS server, as well as one installed in the project directory.

Expected behavior

Extension should interface with the LSP, validating code, returning code suggestions, etc.

Screenshots

Screenshot 2020-09-22 at 18 08 46@2x

Environment

  • Nova version: 1.1 204636 (Beta with LSP crash fix)
  • Extension version: 1.7.0
  • TypeScript version: 4.0.3
  • Sidebar information: Status: Running, TypeScript: Version 4.0.2
  • macOS version: 10.15.6
  • NodeJS information:
    • node version: v14.11.0
    • npm version: 6.14.8
    • installation method: asdf

Extension console output

TypeScript[18:04:47.491000] activating...
TypeScript[18:04:49.579000] using tslib at: /Users/ketch/Work/test/node_modules/typescript/lib
TypeScript[18:04:49.593000] activated

Additional context

This is a continuation of #59
I've tried installing and running the extension locally, but nothing seems to be getting logged to the .log output. I might be missing something in the dev setup though.
Wish I could provide more information or context, but I haven't been able to gather much else.
Happy to provide any extra information, or follow debugging steps.

Thanks in advance 🙏

@alex-ketch alex-ketch added the bug Something isn't working label Sep 22, 2020
@alex-ketch
Copy link
Contributor Author

Just re-installed Node using NVM which seems to have fixed the issue.
Not sure if you'd like to keep this issue open to track the problem with asdf. Please feel free to close otherwise, thanks.

@alex-ketch alex-ketch changed the title Extension activates but doesn't provide LSP functionality Extension activates but doesn't provide LSP functionality when NodeJS installed by asdf Sep 23, 2020
@apexskier
Copy link
Owner

I'm hoping this is solved by Nova 1.2. At least one of the potential causes has been resolved, so I'm going to close.

@benvp
Copy link

benvp commented Sep 30, 2020

Hm I still experience the same issue when using asdf. Since nova 1.2 the extension isn't crashing anymore, but does not really provide any LSP functionality (no code completion, no errors etc.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants