memetastic

Author: aper-project

_includes/videopages/type1/memetastic.html

@@ -1,10 +1,10 @@
-<div class="col s12 tag-div">
+<!-- <div class="col s12 tag-div">
     <div class="user-content">
       <p>
         Description of this bug.
       </p>
     </div>
-</div>
+</div> -->
 
 <!-- <embed src="/assets/res/videos/NoteBuddy_v1.3.2.mp4" autostart="false"/> -->
 

memetastic.md

@@ -8,8 +8,49 @@ css: ["projects.css"]
 
 |      Device Name     | Android Version |    App Name    | App Version |
 |:--------------------:|:---------------:|:--------------:|:-----------:|
-| Samsung Galaxy Note4 |      6.0.1      | EtchDroid |     1.5    |
+| Samsung Galaxy Note4 |      6.0.1      | MemeTastic |     1.6.7    |
 
 ---
 
-{% include videopages/type1/memetastic.html %}
+{% include videopages/type1/memetastic.html %}
+
+##### Description
+The calling context has a permission check, but the returned file path is read/write without check, thus a crash happens when re-entering the app, when the `onResume` is invoked.
+
+Reproduce crash:
+
+1. enter the app from the home screen and allow the permission request
+2. choose one meme item and enter the ``create meme activity''
+3. go to system setting and revoke the storage permission
+4. go back to the app and it crashes
+
+##### Aper Outputs
+```
+API:
+	<android.os.Environment: java.io.File getExternalStorageDirectory()>
+---
+PERMISSIONS:
+	[android.permission.READ_EXTERNAL_STORAGE,android.permission.WRITE_EXTERNAL_STORAGE]
+---
+CALLCHAIN:
+	net.gsantner.memetastic.activity.MemeCreateActivity.onResume()void
+	 net.gsantner.memetastic.activity.MemeCreateActivity.initMemeSettings(android.os.Bundle)boolean
+	  net.gsantner.memetastic.activity.MemeCreateActivity.extractBitmapFromIntent(android.content.Intent)android.graphics.Bitmap
+	   net.gsantner.opoc.util.ShareUtil.extractFileFromIntent(android.content.Intent)java.io.File
+	    android.os.Environment.getExternalStorageDirectory()java.io.File
+
+======
+
+DANGEROUS: android.permission.READ_EXTERNAL_STORAGE
+	Is Declared: true
+	Check Sites: NONE
+	Request Sites: NONE
+	Has Handle: in <net.gsantner.memetastic.activity.MemeCreateActivity: void onRequestPermissionsResult(int,java.lang.String[],int[])>
+
+---
+DANGEROUS: android.permission.WRITE_EXTERNAL_STORAGE
+	Is Declared: true
+	Check Sites: in <net.gsantner.memetastic.service.AssetUpdater$LoadAssetsThread: void run()>
+	Request Sites: NONE
+	Has Handle: in <net.gsantner.memetastic.activity.MemeCreateActivity: void onRequestPermissionsResult(int,java.lang.String[],int[])>
+```