[SYSTEMDS-3833] Fix seq() length primitive (pos/neg increment)

mboehm7 · mboehm7 · commit 6653ced2e446 · 2025-02-09T13:02:02.000+01:00
diff --git a/src/main/java/org/apache/sysds/runtime/util/UtilFunctions.java b/src/main/java/org/apache/sysds/runtime/util/UtilFunctions.java
@@ -448,7 +448,10 @@ public static long getSeqLength(double from, double to, double incr, boolean che
 				return 0; // invalid loop configuration
 		}
 		long tmp = (long) Math.floor(to/incr - from/incr);
-		return 1L + tmp + ((from+tmp*incr < to) ? 1 : 0);
+		if( incr > 0 )
+			return 1L + tmp + ((from+(tmp+1)*incr <= to) ? 1 : 0);
+		else
+			return 1L + tmp + ((from+(tmp+1)*incr >= to) ? 1 : 0);
 	}
 	
 	/**

Original file line number	Diff line number	Diff line change
`@@ -448,7 +448,10 @@ public static long getSeqLength(double from, double to, double incr, boolean che`
`448`	`448`	`return 0; // invalid loop configuration`
`449`	`449`	`}`
`450`	`450`	`long tmp = (long) Math.floor(to/incr - from/incr);`
`451`		`- return 1L + tmp + ((from+tmp*incr < to) ? 1 : 0);`
	`451`	`+ if( incr > 0 )`
	`452`	`+ return 1L + tmp + ((from+(tmp+1)*incr <= to) ? 1 : 0);`
	`453`	`+ else`
	`454`	`+ return 1L + tmp + ((from+(tmp+1)*incr >= to) ? 1 : 0);`
`452`	`455`	`}`
`453`	`456`
`454`	`457`	`/**`