Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] support custom reject in MemorySafeLinkedBlockingQueue #3763

Closed
1 task done
loongs-zhang opened this issue Jul 27, 2022 · 0 comments · Fixed by #3764
Closed
1 task done

[Task] support custom reject in MemorySafeLinkedBlockingQueue #3763

loongs-zhang opened this issue Jul 27, 2022 · 0 comments · Fixed by #3764
Assignees
@loongs-zhang
Labels
status: volunteer wanted Extra attention is needed

Comments

@loongs-zhang
Copy link
Member

loongs-zhang commented Jul 27, 2022 •
edited
Loading

Description

Now MemorySafeLinkedBlockingQueue just discard directly when #hasRemainedMemory returns true, it's better support custom reject.

see sofastack/sofa-rpc#1213 (comment)

Task List

  • support custom reject in MemorySafeLinkedBlockingQueue.
@loongs-zhang loongs-zhang added the status: volunteer wanted Extra attention is needed label Jul 27, 2022
@loongs-zhang loongs-zhang self-assigned this Jul 27, 2022
loongs-zhang added a commit to loongs-zhang/shenyu that referenced this issue Jul 27, 2022
@loongs-zhang
[ISSUE apache#3763] support custom reject in MemorySafeLinkedBlocking…
f757341 
…Queue
@loongs-zhang loongs-zhang mentioned this issue Jul 27, 2022
Merged
3 tasks
yu199195 pushed a commit that referenced this issue Jul 28, 2022
@loongs-zhang
[ISSUE #3763] support custom reject in MemorySafeLinkedBlockingQueue (#…
d2c362a 
…3764)

* [ISSUE #3763] support custom reject in MemorySafeLinkedBlockingQueue

* fix code style
@loongs-zhang loongs-zhang mentioned this issue Jul 29, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loongs-zhang loongs-zhang

Labels
status: volunteer wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #3763] support custom reject in MemorySafeLinkedBlockingQueue loongs-zhang/shenyu
1 participant
@loongs-zhang