Skip to content

Commit 09c32a3

Browse files
committed
fix PK query
1 parent 865fddf commit 09c32a3

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DatasourceOperations.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,6 @@ public void runWithinTransaction(TransactionCallback callback) throws SQLExcepti
224224

225225
public Integer execute(Connection connection, PreparedQuery preparedQuery) throws SQLException {
226226
try (PreparedStatement statement = connection.prepareStatement(preparedQuery.sql())) {
227-
System.out.println(preparedQuery.sql());
228227
List<Object> params = preparedQuery.parameters();
229228
for (int i = 0; i < params.size(); i++) {
230229
statement.setObject(i + 1, params.get(i));

persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,8 @@ public PolarisGrantRecord lookupGrantRecord(
465465
int privilegeCode) {
466466
try {
467467
List<Object> params =
468-
List.of(securableCatalogId, securableId, granteeCatalogId, privilegeCode, realmId);
468+
List.of(
469+
realmId, securableCatalogId, securableId, granteeCatalogId, granteeId, privilegeCode);
469470
var results =
470471
datasourceOperations.executeSelect(
471472
new PreparedQuery(SQLConstants.GRANT_RECORD_LOOKUP_BY_PK_QUERY, params),

persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/SQLConstants.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,9 @@ public class SQLConstants {
154154
+ SCHEMA
155155
+ "."
156156
+ ModelGrantRecord.TABLE_NAME
157-
+ " WHERE securable_catalog_id = ? AND securable_id = ? AND grantee_catalog_id = ? AND privilege_code = ? AND realm_id = ?";
157+
+ " WHERE "
158+
+ String.join(" = ? AND ", ModelGrantRecord.PK_COLUMNS)
159+
+ " = ?";
158160

159161
public static final String GRANT_RECORD_LOOKUP_BY_SECURABLE_QUERY =
160162
"SELECT "

0 commit comments

Comments
 (0)