[core] Don't allow full compaction with lookup changelog producer #6184
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ArnavBalyan
commented
Sep 1, 2025
ArnavBalyan
commented
- Currently there is no check against full compaction on lookup changelog producer.
- User reported unexpected behaviour in [Bug] full-compaction.delta-commits #6183
- Disable setting both the properties together instead of the silent behaviour.
|
I'll check the other changelog producers if we can support full compaction in future, have disabled it to avoid confusion for now cc @junmuz @JingsongLi thanks for reporting |
junmuz
reviewed
Sep 1, 2025
| } | ||
|
|
||
| if (options.toMap().get(FULL_COMPACTION_DELTA_COMMITS.key()) != null | ||
| && changelogProducer == ChangelogProducer.LOOKUP) { |
There was a problem hiding this comment.
I believe the condition should be changelogProducer != ChangelogProducer.FULL_COMPACTION as this property only works with full-compaction changelog producer.
ArnavBalyan
force-pushed
the
arnavb/conversion-issue
branch
from
db3354e to
85edfdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.