Skip to content

Commit 17c1ec9

Browse files
authored
Revert wrapper version removal (#365)
* Revert "[MWRAPPER-143] - The wrapperVersion property is not used in only-script mode (#145)" This reverts commit 91bdb45. * Revert #145, but leave wrapperUrl assertions
1 parent 366207f commit 17c1ec9

File tree

5 files changed

+5
-13
lines changed

5 files changed

+5
-13
lines changed

maven-wrapper-plugin/src/it/projects/default/verify.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,6 @@ Properties props = new Properties()
3434
new File(basedir,'.mvn/wrapper/maven-wrapper.properties').withInputStream {
3535
props.load(it)
3636
}
37+
assert props.wrapperVersion.equals(wrapperCurrentVersion)
3738
assert props.distributionType.equals("only-script")
3839
assert !props.containsKey('wrapperUrl')
39-
assert !props.containsKey("wrapperVersion")

maven-wrapper-plugin/src/it/projects/mavenversion/verify.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@ Properties props = new Properties()
3030
propertiesFile.withInputStream {
3131
props.load(it)
3232
}
33+
assert props.wrapperVersion.equals(wrapperCurrentVersion)
3334
assert props.distributionUrl.endsWith('/org/apache/maven/apache-maven/3.6.3/apache-maven-3.6.3-bin.zip')
3435
assert props.distributionType.equals("only-script")
3536
assert !props.containsKey('wrapperUrl')
36-
assert !props.containsKey("wrapperVersion")
3737

3838
log = new File(basedir, 'build.log').text
3939
// check "mvn wrapper:wrapper" output

maven-wrapper-plugin/src/it/projects/sh_type_only-script/verify.groovy

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@ assert new File(basedir,'mvnw.cmd').exists()
2323
assert !(new File(basedir,'mvnwDebug').exists())
2424
assert !(new File(basedir,'mvnwDebug.cmd').exists())
2525

26-
wrapperProperties = new File(basedir,'.mvn/wrapper/maven-wrapper.properties')
27-
assert wrapperProperties.exists()
28-
assert !wrapperProperties.text.contains('wrapperUrl')
29-
3026
log = new File(basedir, 'build.log').text
3127
// check "mvn wrapper:wrapper" output
3228
assert log.contains('[INFO] Unpacked only-script type wrapper distribution org.apache.maven.wrapper:maven-wrapper-distribution:zip:only-script:')
@@ -39,7 +35,6 @@ Properties props = new Properties()
3935
new File(basedir,'.mvn/wrapper/maven-wrapper.properties').withInputStream {
4036
props.load(it)
4137
}
42-
38+
assert props.wrapperVersion.equals(wrapperCurrentVersion)
4339
assert props.distributionType.equals("only-script")
4440
assert !props.containsKey('wrapperUrl')
45-
assert !props.containsKey("wrapperVersion")

maven-wrapper-plugin/src/it/projects/type_only-script/verify.groovy

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ assert new File(basedir,'mvnw.cmd').exists()
2323
assert !(new File(basedir,'mvnwDebug').exists())
2424
assert !(new File(basedir,'mvnwDebug.cmd').exists())
2525

26-
wrapperProperties = new File(basedir,'.mvn/wrapper/maven-wrapper.properties')
27-
assert wrapperProperties.exists()
28-
2926
log = new File(basedir, 'build.log').text
3027
// check "mvn wrapper:wrapper" output
3128
assert log.contains('[INFO] Unpacked only-script type wrapper distribution org.apache.maven.wrapper:maven-wrapper-distribution:zip:only-script:')
@@ -38,6 +35,6 @@ Properties props = new Properties()
3835
new File(basedir,'.mvn/wrapper/maven-wrapper.properties').withInputStream {
3936
props.load(it)
4037
}
38+
assert props.wrapperVersion.equals(wrapperCurrentVersion)
4139
assert props.distributionType.equals("only-script")
4240
assert !props.containsKey('wrapperUrl')
43-
assert !props.containsKey("wrapperVersion")

maven-wrapper-plugin/src/main/java/org/apache/maven/plugins/wrapper/WrapperMojo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,14 +326,14 @@ private void replaceProperties(String wrapperVersion, Path targetFolder) throws
326326
+ buffer().strong("Maven " + mavenVersion) + " and download from " + repoUrl);
327327

328328
try (BufferedWriter out = Files.newBufferedWriter(wrapperPropertiesFile, StandardCharsets.UTF_8)) {
329+
out.append("wrapperVersion=" + wrapperVersion + System.lineSeparator());
329330
out.append(DISTRIBUTION_TYPE_PROPERTY_NAME + "=" + distributionType + System.lineSeparator());
330331
out.append("distributionUrl=" + finalDistributionUrl + System.lineSeparator());
331332
if (distributionSha256Sum != null) {
332333
out.append("distributionSha256Sum=" + distributionSha256Sum + System.lineSeparator());
333334
}
334335
if (!distributionType.equals(TYPE_ONLY_SCRIPT)) {
335336
out.append("wrapperUrl=" + wrapperUrl + System.lineSeparator());
336-
out.append("wrapperVersion=" + wrapperVersion + System.lineSeparator());
337337
}
338338
if (wrapperSha256Sum != null) {
339339
out.append("wrapperSha256Sum=" + wrapperSha256Sum + System.lineSeparator());

0 commit comments

Comments
 (0)