Skip to content

Remove the last PriorityQueue subclasses #14872

@thecoop

Description

@thecoop

After the various PRs changing PriorityQueue to use Comparator or LessThan functional interfaces, there are only a few subclasses remaining before we can make PriorityQueue final:

  • TermsMergeQueue. This has some additional state in the stack variable
  • FieldValueHitQueue. This is further subclassed, and is public (although experimental)
  • HitQueue. Public class (although internal). Used in several difference places, so this class represents some common functionality.
  • TopDocs.ScoreMergeSortQueue, TopDocs.MergeSortQueue. Has some significant state fields in them
  • TopOrdAndNumberQueue and subclasses. Part of the public API, and has some abstract behavious set by subclasses
  • SuggestWordQueue. Public API

How should we handle these?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions