Skip to content

Commit ffbe09e

Browse files
committed
incorporated feedback from Stephen Webb to release review instructions
1 parent f81fa5f commit ffbe09e

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

src/log4net.sln

+1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".doc", ".doc", "{33D80AD3-8
4747
..\doc\MailTemplate.Result.txt = ..\doc\MailTemplate.Result.txt
4848
..\doc\MailTemplate.txt = ..\doc\MailTemplate.txt
4949
site\xdoc\release\release-notes.xml = site\xdoc\release\release-notes.xml
50+
site\xdoc\release\release-review-instructions.xml = site\xdoc\release\release-review-instructions.xml
5051
..\doc\RELEASING.md = ..\doc\RELEASING.md
5152
EndProjectSection
5253
EndProject

src/site/xdoc/release/release-review-instructions.xml

+7-3
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,16 @@ limitations under the License.
3232
<li>
3333
Prerequisites (winget - in case of problems see next section choco)
3434
<pre class="code">winget install -e --id GnuPG.Gpg4win
35-
winget install -e --id TortoiseSVN.TortoiseSVN
35+
winget install -e --id TortoiseSVN.TortoiseSVN # or any other subversion client
3636
winget install -e --id Mono.Mono
3737
winget install -e --id Microsoft.DotNet.SDK.8</pre>
38+
<p>After installation, verify that gpg and svn are in the path and add them when not.</p>
3839
</li>
3940
<li>
4041
Prerequisites (choco - only in case of problems with winget)
4142
<pre class="code">Set-ExecutionPolicy Bypass -Scope Process -Force; [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; iex ((New-Object System.Net.WebClient).DownloadString('https://community.chocolatey.org/install.ps1'))
4243
choco install gpg4win
43-
choco install tortoisesvn
44+
choco install tortoisesvn # or any other subversion client
4445
choco install mono
4546
choco install dotnet-8.0-sdk</pre>
4647
</li>
@@ -54,7 +55,10 @@ pushd log4net-{releaseVersion}</pre>
5455
<pre class="code">&amp; ./verify-release.ps1</pre>
5556
</li>
5657
<li>
57-
<p>Verify the build</p>
58+
switch to the directory where you extracted the sources (in case you didn't use verify-release.ps1)
59+
</li>
60+
<li>
61+
Verify the build
5862
<pre class="code">dotnet test ./src/log4net.sln</pre>
5963
</li>
6064
</ol>

0 commit comments

Comments
 (0)