Merge pull request #201 from apache/Feature/NetAnalyzers

Enable Microsoft.CodeAnalysis.NetAnalyzers

Author: FreeAndNil

src/Directory.Build.props

@@ -6,15 +6,25 @@
     <LangVersion>latest</LangVersion>
     <Nullable>Enable</Nullable>
     <WarningsAsErrors>nullable</WarningsAsErrors>
+    <AnalysisLevel>8</AnalysisLevel>
+    <RunAnalyzersDuringBuild>true</RunAnalyzersDuringBuild>
+    <RunAnalyzersDuringLiveAnalysis>true</RunAnalyzersDuringLiveAnalysis>
+    <_SkipUpgradeNetAnalyzersNuGetWarning>true</_SkipUpgradeNetAnalyzersNuGetWarning>
+    <AccelerateBuildsInVisualStudio>true</AccelerateBuildsInVisualStudio>
   </PropertyGroup>
   <PropertyGroup Label="Package Versions">
     <SystemConfigurationConfigurationManagerPackageVersion>4.5.0</SystemConfigurationConfigurationManagerPackageVersion>
     <MicrosoftSourceLinkGitHubPackageVersion>8.0.0</MicrosoftSourceLinkGitHubPackageVersion>
+    <!-- Analyzer packages -->
+    <MicrosoftNetAnalyzersPackageVersion>8.0.0</MicrosoftNetAnalyzersPackageVersion>
     <!-- Test Packages -->
     <MicrosoftNetTestSdkPackageVersion>17.11.1</MicrosoftNetTestSdkPackageVersion>
     <NUnitAnalyzersPackageVersion>4.3.0</NUnitAnalyzersPackageVersion>
     <NUnitPackageVersion>4.2.2</NUnitPackageVersion>
     <NUnit3TestAdapterPackageVersion>4.6.0</NUnit3TestAdapterPackageVersion>
     <QuackersTestLoggerPackageVersion>1.0.25</QuackersTestLoggerPackageVersion>
   </PropertyGroup>
+  <ItemGroup>
+    <GlobalAnalyzerConfigFiles Include="$(MSBuildThisFileDirectory)\log4net.globalconfig" />
+  </ItemGroup>
 </Project>

src/log4net.Tests/Appender/AdoNet/Log4NetCommand.cs

@@ -24,7 +24,7 @@
 
 namespace log4net.Tests.Appender.AdoNet;
 
-public class Log4NetCommand : IDbCommand
+internal sealed class Log4NetCommand : IDbCommand
 {
   public Log4NetCommand()
   {
@@ -48,10 +48,7 @@ public int ExecuteNonQuery()
 
   public int ExecuteNonQueryCount { get; private set; }
 
-  public IDbDataParameter CreateParameter()
-  {
-    return new Log4NetParameter();
-  }
+  public IDbDataParameter CreateParameter() => new Log4NetParameter();
 
 #pragma warning disable CS8766 // Nullability of reference types in return type doesn't match implicitly implemented member (possibly because of nullability attributes).
   public string? CommandText { get; set; }
@@ -68,25 +65,13 @@ public void Prepare()
 
   public static Log4NetCommand? MostRecentInstance { get; private set; }
 
-  public void Cancel()
-  {
-    throw new NotImplementedException();
-  }
+  public void Cancel() => throw new NotImplementedException();
 
-  public IDataReader ExecuteReader()
-  {
-    throw new NotImplementedException();
-  }
+  public IDataReader ExecuteReader() => throw new NotImplementedException();
 
-  public IDataReader ExecuteReader(CommandBehavior behavior)
-  {
-    throw new NotImplementedException();
-  }
+  public IDataReader ExecuteReader(CommandBehavior behavior) => throw new NotImplementedException();
 
-  public object ExecuteScalar()
-  {
-    throw new NotImplementedException();
-  }
+  public object ExecuteScalar() => throw new NotImplementedException();
 
   public IDbConnection? Connection
   {