Skip to content

Commit 45f4086

Browse files
committed
Add debug logging for file deletion and fix base name path handling in RollingFileAppender for positive CountDirection, extension preservation and logs in dir
1 parent 13f648f commit 45f4086

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/log4net/Appender/RollingFileAppender.cs

+4-1
Original file line numberDiff line numberDiff line change
@@ -1171,8 +1171,11 @@ protected bool FileExists(string path)
11711171
/// </remarks>
11721172
protected void DeleteFile(string fileName)
11731173
{
1174+
LogLog.Debug(_declaringType, $"Trying to delete [{fileName}]");
1175+
11741176
if (!FileExists(fileName))
11751177
{
1178+
LogLog.Debug(_declaringType, $"[{fileName}] does not exist");
11761179
return;
11771180
}
11781181
// We may not have permission to delete the file, or the file may be locked
@@ -1346,7 +1349,7 @@ protected virtual void RollOverRenameFiles(string baseFileName)
13461349
if (PreserveLogFileNameExtension)
13471350
{
13481351
string extension = Path.GetExtension(archiveFileBaseName);
1349-
string baseName = Path.GetFileNameWithoutExtension(archiveFileBaseName);
1352+
string baseName = Path.Combine(Path.GetDirectoryName(archiveFileBaseName), Path.GetFileNameWithoutExtension(archiveFileBaseName));
13501353
int lastDotIndex = baseName.LastIndexOf(".", StringComparison.Ordinal);
13511354
if (lastDotIndex >= 0)
13521355
{

0 commit comments

Comments
 (0)