Skip to content

Commit 2d68abc

Browse files
Turn on the CI build for PRs (#204)
* Divide steps * Try the approach from build doc * Add PR trigger * Fix branch name * Try dotnet build & test * Enable quackers * Remove Zarro from the CI build
1 parent 0f8b41c commit 2d68abc

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

.github/workflows/build.yaml

+14-12
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ name: build
1919

2020
on:
2121
workflow_dispatch:
22+
push:
23+
branches:
24+
- master
25+
pull_request:
2226

2327
jobs:
2428

@@ -31,6 +35,10 @@ jobs:
3135
matrix:
3236
os: [ macos-latest, ubuntu-latest, windows-latest ]
3337

38+
env:
39+
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
40+
DOTNET_CLI_TELEMETRY_OPTOUT: 1
41+
3442
steps:
3543

3644
- name: Checkout repository
@@ -42,16 +50,10 @@ jobs:
4250
dotnet-version: 8
4351
dotnet-quality: ga
4452

45-
- name: Set up NodeJs
46-
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # 4.0.3
47-
with:
48-
node-version: 20
49-
50-
- name: Build and test
51-
env:
52-
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
53-
DOTNET_CLIE_TELEMETRY_OPTOUT: 1
53+
- name: Build
54+
run: |
55+
dotnet build ./src/log4net.sln
56+
57+
- name: Test
5458
run: |
55-
npm update -g npm --no-progress
56-
npm install --no-progress
57-
npm test
59+
dotnet test ./src/log4net.sln

src/log4net.Tests/log4net.Tests.csproj

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
<DefineConstants>TRACE;DEBUG;$(DefineConstants)</DefineConstants>
1313
<!-- suppress analyzer mismatch warning -->
1414
<NoWarn>CS8032</NoWarn>
15+
<VSTestLogger>quackers</VSTestLogger>
1516
</PropertyGroup>
1617
<ItemGroup>
1718
<Compile Include="..\log4net\Diagnostics\CodeAnalysis\CallerArgumentExpressionAttribute.cs" Link="Diagnostics\CodeAnalysis\CallerArgumentExpressionAttribute.cs" />

0 commit comments

Comments
 (0)