PoC: Add rewrite support for errorprone.refasterrules.FileRulesRecipes

Author: Vincent Potucek

.github/workflows/build.yml

@@ -140,7 +140,12 @@ jobs:
         # --scan:         Publish the build scan. This will only work on PRs from apache/kafka and trunk
         # --no-scan:      For public fork PRs, we won't attempt to publish the scan
         run: |
-          ./gradlew --build-cache --info $SCAN_ARG check releaseTarGz -x test
+          ./gradlew --build-cache --info $SCAN_ARG check releaseTarGz -x test -x rewriteDryRun
+      - name: Rewrite
+        env:
+          SCAN_ARG: ${{ inputs.is-public-fork && '--no-scan' || '--scan' }}
+        run: |
+          ./gradlew --build-cache --info $SCAN_ARG rewriteDryRun
       - name: Archive check reports
         if: always()
         uses: actions/upload-artifact@v4

README.md

@@ -201,7 +201,17 @@ For experiments (or regression testing purposes) add `-PcheckstyleVersion=X.y.z`
 #### Spotless ####
 The import order is a part of static check. please call `spotlessApply` to optimize the imports of Java codes before filing pull request.
 
-    ./gradlew spotlessApply
+`./gradlew spotlessApply`
+
+#### Rewrite
+The build system incorporates [Moderne](https://moderne.io/) rewrite capabilities for automated code transformations.
+
+- **Convention** (e.g., JUnit's naming rules)
+- **Refactor** safely (e.g., rename methods, migrate APIs)
+- **Modernize** (e.g., Java 8 → Java 17 features)
+- **Patterns** (e.g., replace `Vector` with `ArrayList`)
+
+`./gradlew rewriteRun`
 
 #### Spotbugs ####
 Spotbugs uses static analysis to look for bugs in the code.

build.gradle

@@ -13,6 +13,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+import com.github.spotbugs.snom.SpotBugsTask
 import org.ajoberstar.grgit.Grgit
 import java.nio.charset.StandardCharsets
 
@@ -29,20 +30,25 @@ buildscript {
 }
 
 plugins {
-  id 'com.github.ben-manes.versions' version '0.48.0'
-  id 'idea'
-  id 'jacoco'
-  id 'java-library'
-  id 'org.owasp.dependencycheck' version '8.2.1'
-  id 'org.nosphere.apache.rat' version "0.8.1"
+  id "com.diffplug.spotless" version "6.25.0" apply false
+  id "com.github.ben-manes.versions" version "0.48.0"
+  id "com.github.spotbugs" version "6.0.25" apply false
+  id "com.gradleup.shadow" version "8.3.6" apply false
+  id "idea"
   id "io.swagger.core.v3.swagger-gradle-plugin" version "${swaggerVersion}"
-
-  id "com.github.spotbugs" version '6.0.25' apply false
-  id 'org.scoverage' version '8.0.3' apply false
-  id 'com.gradleup.shadow' version '8.3.6' apply false
-  id 'com.diffplug.spotless' version "6.25.0"
+  id "jacoco"
+  id "java-library"
+  id "org.nosphere.apache.rat" version "0.8.1"
+  id "org.openrewrite.rewrite" version "7.12.1" apply false
+  id "org.owasp.dependencycheck" version "8.2.1"
+  id "org.scoverage" version "8.0.3" apply false
 }
 
+apply from: "$rootDir/gradle/.qa/checkstyle.gradle"
+apply from: "$rootDir/gradle/.qa/rewrite.gradle"
+apply from: "$rootDir/gradle/.qa/spotbugs.gradle"
+apply from: "$rootDir/gradle/.qa/spotless.gradle"
+
 ext {
   gradleVersion = versions.gradle
   minClientJavaVersion = 11
@@ -157,7 +163,7 @@ ext {
     libs.log4j2Api,
     libs.log4j2Core
   ]
-  
+
 }
 
 allprojects {
@@ -312,8 +318,6 @@ subprojects {
   task allDepInsight(type: DependencyInsightReportTask) {showingAllVariants = false} doLast {}
 
   apply plugin: 'java-library'
-  apply plugin: 'checkstyle'
-  apply plugin: "com.github.spotbugs"
 
   // We use the shadow plugin for the jmh-benchmarks module and the `-all` jar can get pretty large, so
   // don't publish it
@@ -749,32 +753,7 @@ subprojects {
     }
   }
 
-  checkstyle {
-    configDirectory = rootProject.layout.projectDirectory.dir("checkstyle")
-    configProperties = checkstyleConfigProperties("import-control.xml")
-    toolVersion = versions.checkstyle
-  }
-
-  configure(checkstyleMain) {
-    group = 'Verification'
-    description = 'Run checkstyle on all main Java sources'
-  }
-
-  configure(checkstyleTest) {
-    group = 'Verification'
-    description = 'Run checkstyle on all test Java sources'
-  }
-
-  test.dependsOn('checkstyleMain', 'checkstyleTest')
-
-  spotbugs {
-    toolVersion = versions.spotbugs
-    excludeFilter = file("$rootDir/gradle/spotbugs-exclude.xml")
-    ignoreFailures = false
-  }
-  test.dependsOn('spotbugsMain')
-
-  tasks.withType(com.github.spotbugs.snom.SpotBugsTask).configureEach {
+  tasks.withType(SpotBugsTask).configureEach {
     reports.configure {
       // Continue supporting `xmlFindBugsReport` for compatibility
       xml.enabled(project.hasProperty('xmlSpotBugsReport') || project.hasProperty('xmlFindBugsReport'))
@@ -816,20 +795,6 @@ subprojects {
     skipProjects = [ ":jmh-benchmarks", ":trogdor" ]
     skipConfigurations = [ "zinc" ]
   }
-  apply plugin: 'com.diffplug.spotless'
-  spotless {
-    java {
-      targetExclude('**/generated/**/*.java','**/generated-test/**/*.java')
-      importOrder('kafka', 'org.apache.kafka', 'com', 'net', 'org', 'java', 'javax', '', '\\#')
-      removeUnusedImports()
-    }
-  }
-}
-
-gradle.taskGraph.whenReady { taskGraph ->
-  taskGraph.getAllTasks().findAll { it.name.contains('spotbugsScoverage') || it.name.contains('spotbugsTest') }.each { task ->
-    task.enabled = false
-  }
 }
 
 def fineTuneEclipseClasspathFile(eclipse, project) {
@@ -2812,14 +2777,6 @@ project(':streams:streams-scala') {
     dependsOn 'copyDependantLibs'
   }
 
-  apply plugin: 'com.diffplug.spotless'
-  spotless {
-    scala {
-      target '**/*.scala'
-      scalafmt("$versions.scalafmt").configFile('../../checkstyle/.scalafmt.conf').scalaMajorVersion(versions.baseScala)
-      licenseHeaderFile '../../checkstyle/java.header', 'package'
-    }
-  }
 }
 
 project(':streams:integration-tests') {

clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/OAuthBearerTest.java

@@ -46,6 +46,7 @@
 import java.net.URL;
 import java.nio.ByteBuffer;
 import java.nio.channels.FileChannel;
+import java.nio.file.Files;
 import java.nio.file.StandardOpenOption;
 import java.security.KeyPair;
 import java.security.KeyPairGenerator;
@@ -236,7 +237,7 @@ protected JwtConsumer jwtConsumer(PublicKey publicKey) {
     }
 
     protected File generatePrivateKey(PrivateKey privateKey) throws IOException {
-        File file = File.createTempFile("private-", ".key");
+        File file = Files.createTempFile("private-", ".key").toFile();
         byte[] bytes = Base64.getEncoder().encode(privateKey.getEncoded());
 
         try (FileChannel channel = FileChannel.open(file.toPath(), EnumSet.of(StandardOpenOption.WRITE))) {

connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java

@@ -53,7 +53,7 @@ public class FileStreamSourceTaskTest {
 
     @BeforeEach
     public void setup() throws IOException {
-        tempFile = File.createTempFile("file-stream-source-task-test", null);
+        tempFile = Files.createTempFile("file-stream-source-task-test", null).toFile();
         config = new HashMap<>();
         config.put(FileStreamSourceConnector.FILE_CONFIG, tempFile.getAbsolutePath());
         config.put(FileStreamSourceConnector.TOPIC_CONFIG, TOPIC);

connect/runtime/src/test/java/org/apache/kafka/connect/storage/FileOffsetBackingStoreTest.java

@@ -81,7 +81,7 @@ public void setup() {
         when(converter.toConnectData(anyString(), any(byte[].class))).thenReturn(new SchemaAndValue(null,
                 Arrays.asList("connector", Collections.singletonMap("partitionKey", "dummy"))));
         store = new FileOffsetBackingStore(converter);
-        tempFile = assertDoesNotThrow(() -> File.createTempFile("fileoffsetbackingstore", null));
+        tempFile = assertDoesNotThrow(() -> Files.createTempFile("fileoffsetbackingstore", null).toFile());
         Map<String, String> props = new HashMap<>();
         props.put(StandaloneConfig.OFFSET_STORAGE_FILE_FILENAME_CONFIG, tempFile.getAbsolutePath());
         props.put(StandaloneConfig.KEY_CONVERTER_CLASS_CONFIG, "org.apache.kafka.connect.json.JsonConverter");

connect/runtime/src/test/resources/test-plugins/bad-packaging/test/plugins/StaticInitializerThrowsRestExtension.java

@@ -18,14 +18,10 @@
 package test.plugins;
 
 import java.io.IOException;
-import java.util.List;
 import java.util.Map;
 
-import org.apache.kafka.common.config.ConfigDef;
-import org.apache.kafka.connect.connector.Task;
 import org.apache.kafka.connect.rest.ConnectRestExtension;
 import org.apache.kafka.connect.rest.ConnectRestExtensionContext;
-import org.apache.kafka.connect.sink.SinkConnector;
 
 /**
  * Fake plugin class for testing classloading isolation.

connect/runtime/src/test/resources/test-plugins/classpath-converter/org/apache/kafka/connect/converters/ByteArrayConverter.java

@@ -19,17 +19,14 @@
 import org.apache.kafka.common.config.ConfigDef;
 import org.apache.kafka.common.utils.AppInfoParser;
 import org.apache.kafka.connect.components.Versioned;
-import org.apache.kafka.connect.connector.Task;
 import org.apache.kafka.connect.data.Schema;
 import org.apache.kafka.connect.data.SchemaAndValue;
 import org.apache.kafka.connect.errors.DataException;
-import org.apache.kafka.connect.sink.SinkConnector;
 import org.apache.kafka.connect.storage.Converter;
 import org.apache.kafka.connect.storage.ConverterConfig;
 import org.apache.kafka.connect.storage.HeaderConverter;
 
 import java.nio.ByteBuffer;
-import java.util.List;
 import java.util.Map;
 
 public class ByteArrayConverter implements Converter, HeaderConverter, Versioned {

connect/runtime/src/test/resources/test-plugins/sampling-config-provider/test/plugins/SamplingConfigProvider.java

@@ -27,11 +27,7 @@
 import org.apache.kafka.common.config.provider.ConfigProvider;
 import org.apache.kafka.common.config.ConfigData;
 import org.apache.kafka.common.config.ConfigChangeCallback;
-import org.apache.kafka.connect.data.Schema;
-import org.apache.kafka.connect.data.SchemaAndValue;
-import org.apache.kafka.connect.storage.Converter;
 import org.apache.kafka.connect.runtime.isolation.SamplingTestPlugin;
-import org.apache.kafka.connect.storage.HeaderConverter;
 
 /**
  * Fake plugin class for testing classloading isolation.

connect/runtime/src/test/resources/test-plugins/sampling-connector/test/plugins/SamplingConnector.java

@@ -17,7 +17,6 @@
 
 package test.plugins;
 
-import java.io.IOException;
 import java.util.Collections;
 import java.util.ArrayList;
 import java.util.List;