Skip to content

Commit 183998e

Browse files
committed
KAFKA-18399 Remove ZooKeeper from KafkaApis (6/N): USER_SCRAM_CREDENTIALS
1 parent c28d9a3 commit 183998e

File tree

1 file changed

+2
-19
lines changed

1 file changed

+2
-19
lines changed

Diff for: core/src/main/scala/kafka/server/KafkaApis.scala

+2-19
Original file line numberDiff line numberDiff line change
@@ -3370,10 +3370,7 @@ class KafkaApis(val requestChannel: RequestChannel,
33703370
} else {
33713371
metadataSupport match {
33723372
case ZkSupport(adminManager, controller, zkClient, forwardingManager, metadataCache, _) =>
3373-
val result = adminManager.describeUserScramCredentials(
3374-
Option(describeUserScramCredentialsRequest.data.users).map(_.asScala.map(_.name).toList))
3375-
requestHelper.sendResponseMaybeThrottle(request, requestThrottleMs =>
3376-
new DescribeUserScramCredentialsResponse(result.setThrottleTimeMs(requestThrottleMs)))
3373+
throw KafkaApis.shouldNeverReceive(request)
33773374
case RaftSupport(_, metadataCache) =>
33783375
val result = metadataCache.describeScramCredentials(describeUserScramCredentialsRequest.data())
33793376
requestHelper.sendResponseMaybeThrottle(request, requestThrottleMs =>
@@ -3383,21 +3380,7 @@ class KafkaApis(val requestChannel: RequestChannel,
33833380
}
33843381

33853382
def handleAlterUserScramCredentialsRequest(request: RequestChannel.Request): Unit = {
3386-
val zkSupport = metadataSupport.requireZkOrThrow(KafkaApis.shouldAlwaysForward(request))
3387-
val alterUserScramCredentialsRequest = request.body[AlterUserScramCredentialsRequest]
3388-
3389-
if (!zkSupport.controller.isActive) {
3390-
requestHelper.sendResponseMaybeThrottle(request, requestThrottleMs =>
3391-
alterUserScramCredentialsRequest.getErrorResponse(requestThrottleMs, Errors.NOT_CONTROLLER.exception))
3392-
} else if (authHelper.authorize(request.context, ALTER, CLUSTER, CLUSTER_NAME)) {
3393-
val result = zkSupport.adminManager.alterUserScramCredentials(
3394-
alterUserScramCredentialsRequest.data.upsertions().asScala, alterUserScramCredentialsRequest.data.deletions().asScala)
3395-
requestHelper.sendResponseMaybeThrottle(request, requestThrottleMs =>
3396-
new AlterUserScramCredentialsResponse(result.setThrottleTimeMs(requestThrottleMs)))
3397-
} else {
3398-
requestHelper.sendResponseMaybeThrottle(request, requestThrottleMs =>
3399-
alterUserScramCredentialsRequest.getErrorResponse(requestThrottleMs, Errors.CLUSTER_AUTHORIZATION_FAILED.exception))
3400-
}
3383+
throw KafkaApis.shouldAlwaysForward(request)
34013384
}
34023385

34033386
def handleAlterPartitionRequest(request: RequestChannel.Request): Unit = {

0 commit comments

Comments
 (0)