Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom DocumentID override is not capable in DeletionBolt #1133

Closed
chhsiao90 opened this issue Dec 12, 2023 · 3 comments
Closed

custom DocumentID override is not capable in DeletionBolt #1133

chhsiao90 opened this issue Dec 12, 2023 · 3 comments
Labels
elasticsearch enhancement OpenSearch
Milestone
2.11

Comments

@chhsiao90
Copy link
Contributor

chhsiao90 commented Dec 12, 2023 •
edited
Loading

What kind of issue is this? Feature request

This feature was already implemented in #1028 and #1036 for indexer and status bolts, but not in deletion bolt.
@chhsiao90
Copy link
Contributor Author

chhsiao90 commented Dec 12, 2023 •
edited
Loading

Please let me know if we'd like to have this feature in deletion bolt and I can have a PR for it. And a question about the implementation is that should we have an AbstractDeletionBolt?

@rzo1
Copy link
Contributor

rzo1 commented Dec 12, 2023

This feature was already implemented in #1028 and #1036 for indexer and status bolts, but in deletion bolt.

Feel free to open a PR for it.

@jnioche jnioche added this to the 2.11 milestone Dec 12, 2023
@jnioche
Copy link
Contributor

jnioche commented Dec 12, 2023

Thanks a lot @chhsiao90

@jnioche jnioche closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
elasticsearch enhancement OpenSearch
Projects
None yet
Milestone
2.11
Development

No branches or pull requests
3 participants
@jnioche @chhsiao90 @rzo1