Fix some tests

Author: Fokko

crates/iceberg/src/expr/visitors/manifest_evaluator.rs

@@ -258,7 +258,7 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_> {
                 lower_bound_bytes,
                 *reference.field().field_type.clone(),
             );
-            if datum > &lower_bound {
+            if &lower_bound > datum {
                 return ROWS_CANNOT_MATCH;
             }
         }
@@ -268,7 +268,7 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_> {
                 upper_bound_bytes,
                 *reference.field().field_type.clone(),
             );
-            if datum < &upper_bound {
+            if &upper_bound < datum {
                 return ROWS_CANNOT_MATCH;
             }
         }
@@ -381,21 +381,21 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_> {
         }
 
         if let Some(lower_bound) = &field.lower_bound {
-            let d = ManifestFilterVisitor::bytes_to_datum(
+            let lower_bound = ManifestFilterVisitor::bytes_to_datum(
                 lower_bound,
                 *reference.field().clone().field_type,
             );
-            if literals.iter().all(|datum| &d < datum) {
+            if literals.iter().all(|datum| &lower_bound > datum) {
                 return ROWS_CANNOT_MATCH;
             }
         }
 
         if let Some(upper_bound) = &field.upper_bound {
-            let d = ManifestFilterVisitor::bytes_to_datum(
+            let upper_bound = ManifestFilterVisitor::bytes_to_datum(
                 upper_bound,
                 *reference.field().clone().field_type,
             );
-            if literals.iter().all(|datum| &d < datum) {
+            if literals.iter().all(|datum| &upper_bound < datum) {
                 return ROWS_CANNOT_MATCH;
             }
         }

crates/iceberg/src/inspect/manifests.rs

@@ -261,6 +261,7 @@ impl<'a> ManifestsTable<'a> {
                 .field_type
                 .as_primitive_type()
                 .unwrap();
+
             partition_summaries_builder
                 .field_builder::<StringBuilder>(2)
                 .unwrap()

crates/iceberg/src/spec/manifest_list.rs

@@ -1144,7 +1144,7 @@ mod test {
                 added_rows_count: Some(3),
                 existing_rows_count: Some(0),
                 deleted_rows_count: Some(0),
-                partitions: Some(vec![]),
+                partitions: None,
                 key_metadata: vec![],
             }]
         }.try_into().unwrap();