feat: introduce DeleteVector struct to decouple consumers from implementation details

Author: sdd

crates/iceberg/src/arrow/delete_file_manager.rs

@@ -15,8 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
-use roaring::RoaringTreemap;
-
+use crate::delete_vector::DeleteVector;
 use crate::expr::BoundPredicate;
 use crate::io::FileIO;
 use crate::scan::{ArrowRecordBatchStream, FileScanTaskDeleteFile};
@@ -42,7 +41,10 @@ impl DeleteFileManager for CachingDeleteFileManager {
     fn read_delete_file(_task: &FileScanTaskDeleteFile) -> Result<ArrowRecordBatchStream> {
         // TODO, implementation in https://github.com/apache/iceberg-rust/pull/982
 
-        unimplemented!()
+        Err(Error::new(
+            ErrorKind::FeatureUnsupported,
+            "Reading delete files is not yet supported",
+        ))
     }
 }
 
@@ -83,7 +85,7 @@ impl CachingDeleteFileManager {
     pub(crate) fn get_positional_delete_indexes_for_data_file(
         &self,
         data_file_path: &str,
-    ) -> Option<RoaringTreemap> {
+    ) -> Option<DeleteVector> {
         // TODO
 
         None

crates/iceberg/src/arrow/reader.rs

@@ -38,11 +38,11 @@ use parquet::arrow::async_reader::AsyncFileReader;
 use parquet::arrow::{ParquetRecordBatchStreamBuilder, ProjectionMask, PARQUET_FIELD_ID_META_KEY};
 use parquet::file::metadata::{ParquetMetaData, ParquetMetaDataReader, RowGroupMetaData};
 use parquet::schema::types::{SchemaDescriptor, Type as ParquetType};
-use roaring::RoaringTreemap;
 
 use crate::arrow::delete_file_manager::CachingDeleteFileManager;
 use crate::arrow::record_batch_transformer::RecordBatchTransformer;
 use crate::arrow::{arrow_schema_to_schema, get_arrow_datum};
+use crate::delete_vector::DeleteVector;
 use crate::error::Result;
 use crate::expr::visitors::bound_predicate_visitor::{visit, BoundPredicateVisitor};
 use crate::expr::visitors::page_index_evaluator::PageIndexEvaluator;
@@ -346,7 +346,7 @@ impl ArrowReader {
     fn build_deletes_row_selection(
         row_group_metadata: &[RowGroupMetaData],
         selected_row_groups: &Option<Vec<usize>>,
-        mut positional_deletes: RoaringTreemap,
+        mut positional_deletes: DeleteVector,
     ) -> Result<RowSelection> {
         // TODO
 

crates/iceberg/src/lib.rs

@@ -87,4 +87,5 @@ pub(crate) mod delete_file_index;
 mod utils;
 pub mod writer;
 
+mod delete_vector;
 mod puffin;