Skip to content

Commit 479e663

Browse files
authored
update daft links (#2169)
<!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change We recently changed our site domain so want to update all Daft documentation links. And noticed that our package should be updated from `getdaft` to `daft` # Are these changes tested? yes # Are there any user-facing changes? no <!-- In the case of user-facing changes, please add the changelog label. -->
1 parent 3fb92aa commit 479e663

File tree

4 files changed

+61
-68
lines changed

4 files changed

+61
-68
lines changed

mkdocs/docs/api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1525,7 +1525,7 @@ print(ray_dataset.take(2))
15251525

15261526
### Daft
15271527

1528-
PyIceberg interfaces closely with Daft Dataframes (see also: [Daft integration with Iceberg](https://www.getdaft.io/projects/docs/en/stable/integrations/iceberg/)) which provides a full lazily optimized query engine interface on top of PyIceberg tables.
1528+
PyIceberg interfaces closely with Daft Dataframes (see also: [Daft integration with Iceberg](https://docs.daft.ai/en/stable/io/iceberg/)) which provides a full lazily optimized query engine interface on top of PyIceberg tables.
15291529

15301530
<!-- prettier-ignore-start -->
15311531

poetry.lock

Lines changed: 58 additions & 59 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ gcsfs = { version = ">=2023.1.0", optional = true }
7878
huggingface-hub = { version = ">=0.24.0", optional = true }
7979
psycopg2-binary = { version = ">=2.9.6", optional = true }
8080
sqlalchemy = { version = "^2.0.18", optional = true }
81-
getdaft = { version = ">=0.2.12", optional = true }
81+
daft = { version = ">=0.5.0", optional = true }
8282
cachetools = ">=5.5,<7.0"
8383
pyiceberg-core = { version = "^0.5.1", optional = true }
8484
polars = { version = "^1.21.0", optional = true }
@@ -298,7 +298,7 @@ pyarrow = ["pyarrow", "pyiceberg-core"]
298298
pandas = ["pandas", "pyarrow"]
299299
duckdb = ["duckdb", "pyarrow"]
300300
ray = ["ray", "pyarrow", "pandas"]
301-
daft = ["getdaft"]
301+
daft = ["daft"]
302302
polars = ["polars"]
303303
snappy = ["python-snappy"]
304304
hive = ["thrift"]

tests/integration/test_reads.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -321,9 +321,6 @@ def test_pyarrow_limit_with_multiple_files(catalog: Catalog) -> None:
321321
@pytest.mark.integration
322322
@pytest.mark.parametrize("catalog", [pytest.lazy_fixture("session_catalog_hive"), pytest.lazy_fixture("session_catalog")])
323323
def test_daft_nan(catalog: Catalog) -> None:
324-
import daft
325-
326-
daft.context.set_runner_native()
327324
table_test_null_nan_rewritten = catalog.load_table("default.test_null_nan_rewritten")
328325
df = table_test_null_nan_rewritten.to_daft()
329326
assert df.count_rows() == 3
@@ -333,9 +330,6 @@ def test_daft_nan(catalog: Catalog) -> None:
333330
@pytest.mark.integration
334331
@pytest.mark.parametrize("catalog", [pytest.lazy_fixture("session_catalog_hive"), pytest.lazy_fixture("session_catalog")])
335332
def test_daft_nan_rewritten(catalog: Catalog) -> None:
336-
import daft
337-
338-
daft.context.set_runner_native()
339333
table_test_null_nan_rewritten = catalog.load_table("default.test_null_nan_rewritten")
340334
df = table_test_null_nan_rewritten.to_daft()
341335
df = df.where(df["col_numeric"].float.is_nan())

0 commit comments

Comments
 (0)