Skip to content

Commit 322ebdd

Browse files
Nit: Introduce S3_SIGNER constant property (#1837)
1 parent 71cb247 commit 322ebdd

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

pyiceberg/io/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@
6363
S3_PROXY_URI = "s3.proxy-uri"
6464
S3_CONNECT_TIMEOUT = "s3.connect-timeout"
6565
S3_REQUEST_TIMEOUT = "s3.request-timeout"
66+
S3_SIGNER = "s3.signer"
6667
S3_SIGNER_URI = "s3.signer.uri"
6768
S3_SIGNER_ENDPOINT = "s3.signer.endpoint"
6869
S3_SIGNER_ENDPOINT_DEFAULT = "v1/aws/s3/sign"

pyiceberg/io/fsspec.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@
6767
S3_REQUEST_TIMEOUT,
6868
S3_SECRET_ACCESS_KEY,
6969
S3_SESSION_TOKEN,
70+
S3_SIGNER,
7071
S3_SIGNER_ENDPOINT,
7172
S3_SIGNER_ENDPOINT_DEFAULT,
7273
S3_SIGNER_URI,
@@ -137,7 +138,7 @@ def _s3(properties: Properties) -> AbstractFileSystem:
137138
config_kwargs = {}
138139
register_events: Dict[str, Callable[[Properties], None]] = {}
139140

140-
if signer := properties.get("s3.signer"):
141+
if signer := properties.get(S3_SIGNER):
141142
logger.info("Loading signer %s", signer)
142143
if signer_func := SIGNERS.get(signer):
143144
signer_func_with_properties = partial(signer_func, properties)

0 commit comments

Comments
 (0)