Skip to content

Commit 2b84bf5

Browse files
raulcdkevinjqliu
andauthored
fix: redirect only error output from makefile command to do not install uv if already present on system (#2742)
Closes #2741 # Rationale for this change `make install` is currently trying to install `uv` even when is present locally: ```bash $ make install uv not found. Installing... /home/raulcd/.local/bin/uv ^Cmake: *** [Makefile:62: install-uv] Interrupt $ uv --version uv 0.9.7 ``` ## Are these changes tested? No, only validated locally on Debian 14 that it does not try to install: ```bash $ PYTHON=3.12 make install /home/raulcd/.local/bin/uv uv is already installed. uv venv --python 3.12 Using CPython 3.12.12 Creating virtual environment at: .venv ``` And validated in a clean docker container that if `uv` is not present it installs it: ```bash root@9e4870fda91e:/app/iceberg-python# make install uv not found. Installing... downloading uv 0.9.8 x86_64-unknown-linux-gnu no checksums to verify installing to /root/.local/bin ``` ## Are there any user-facing changes? No --------- Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
1 parent ba65619 commit 2b84bf5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ help: ## Display this help message
5959
##@ Setup
6060

6161
install-uv: ## Ensure uv is installed
62-
@if ! command -v uv &> /dev/null; then \
62+
@if ! command -v uv > /dev/null 2>&1; then \
6363
echo "uv not found. Installing..."; \
6464
curl -LsSf https://astral.sh/uv/install.sh | sh; \
6565
else \

0 commit comments

Comments
 (0)