Skip to content

Commit df0ddc7

Browse files
committed
Code Review feedback from converters merge
1 parent 7488665 commit df0ddc7

File tree

3 files changed

+10
-35
lines changed

3 files changed

+10
-35
lines changed

gradle.properties

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ slf4jVersion=2.0.16
1818
rxJava1Version=1.3.8
1919
rxJava2Version=2.2.21
2020
gparsVersion=1.2.1
21-
commonsLang3Version=3.14.0
2221

2322
org.gradle.caching=true
2423
org.gradle.parallel=true

grails-plugin-converters/build.gradle

Lines changed: 10 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -17,32 +17,20 @@ apply plugin: 'java-library'
1717
apply plugin: 'org.grails.grails-plugin'
1818

1919
dependencies {
20-
implementation platform(project(":grails-bom"))
20+
implementation platform(project(':grails-bom'))
21+
2122
api project(':grails-web-common')
2223

23-
implementation "org.apache.commons:commons-lang3:$commonsLang3Version"
24-
implementation "org.codehaus.groovy:groovy-xml:$groovyVersion"
25-
implementation project(':grails-bootstrap')
26-
implementation "org.grails:grails-datastore-gorm"
24+
compileOnly 'jakarta.servlet:jakarta.servlet-api' // Provided
2725

28-
compileOnly "jakarta.servlet:jakarta.servlet-api" // Provided
26+
implementation 'org.apache.commons:commons-lang3'
27+
implementation 'org.grails:grails-datastore-gorm'
28+
implementation project(':grails-bootstrap')
2929

30-
testImplementation "jakarta.servlet:jakarta.servlet-api"
31-
testImplementation project(':grails-core')
30+
testImplementation 'jakarta.servlet:jakarta.servlet-api'
3231
testImplementation 'org.grails:grails-datastore-core'
33-
testImplementation project(':grails-web-common')
34-
testImplementation 'org.springframework:spring-context'
3532
testImplementation 'org.spockframework:spock-core'
36-
37-
documentation 'com.github.javaparser:javaparser-core'
38-
}
39-
40-
tasks.named('bootJar', BootJar) {
41-
enabled = false
42-
mainClass = 'grails.plugin.converters.Application'
43-
}
44-
45-
tasks.named('jar', Jar) {
46-
enabled = true
47-
archiveClassifier = ''
33+
testImplementation 'org.springframework:spring-context'
34+
testImplementation project(':grails-core')
35+
testImplementation project(':grails-web-common')
4836
}

grails-plugin-converters/grails-app/init/org/grails/plugins/converters/Application.groovy

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)