refactor(go): Replace legacy RegisterTagType api call #2696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junjiexh
requested review from
PragmaTwice,
chaokunyang and
theweipeng
as code owners
junjiexh
force-pushed
the
legacy-api-call
branch
from
b67cb17 to
2ad6cb9
Compare
chaokunyang
reviewed
Oct 3, 2025
junjiexh
force-pushed
the
legacy-api-call
branch
from
0cb0c31 to
e2eb7a6
Compare
chaokunyang
reviewed
Oct 6, 2025
chaokunyang
reviewed
Oct 9, 2025
junjiexh
force-pushed
the
legacy-api-call
branch
from
ac9f061 to
8bb1a93
Compare
junjiexh
force-pushed
the
legacy-api-call
branch
from
8bb1a93 to
c5c2f73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
fory-go was using RegisterTagType as register api which is already abandoned in implements in java and python. We need to switch to "typename + namespace" pattern registration.
What does this PR do?
Add two register-api called RegisterType and Register, they all do the same things. The RegisterType will register type on "typename + namespace", and the Register will register type using "namespace.typename" which is less complicated.
Remove the old api RegisterTagType and all its usages.
Related issues
#2611
Does this PR introduce any user-facing change?
Benchmark