-
Notifications
You must be signed in to change notification settings - Fork 436
[doc] use standard Flink docker image in QuickStart #1997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
website/docs/quickstart/flink.md
Outdated
| 2. Create a `docker-compose.yml` file with the following content: | ||
| 2. Create a Dockerfile named `fluss.Dockerfile` as follows. You can adjust the Flink version as needed. Please make sure to download the compatible versions of [fluss-flink connector jar](/downloads), [flink-connector-faker](https://github.com/knaufk/flink-faker/releases) in the Dockerfile. | ||
|
|
||
| ```Dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A docker file looks wried to me. Could we just mount the libs to flink image just like we did for iceberg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
luoyuxia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xx789633 Thanks for the pr. Left some comment
|
Also change |
| #begin Flink cluster | ||
| jobmanager: | ||
| image: apache/fluss-quickstart-flink:1.20-$FLUSS_DOCKER_VERSION$ | ||
| image: flink:${FLINK_VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, with ${FLINK_VERSION}, users can't directly copy & paste the yaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but this saves effort to set the flink version for each component.
Purpose
Linked issue: close #xxx
Brief change log
Tests
API and Format
Documentation