Merge branch 'apache:master' into fix-logarithmic-scale-negative-below-one

Author: Antti-Palola

build/source-release/prepareReleaseMaterials.js

@@ -77,7 +77,7 @@ const stableVersion = `${major}.${minor}.${patch}`;
 const releaseFullName = `Apache ECharts ${stableVersion} (release candidate ${rc})`;
 
 console.log('[Release Repo] ' + repo);
-console.log('[Release Verion] ' + rcVersion);
+console.log('[Release Version] ' + rcVersion);
 console.log('[Release Commit] ' + releaseCommit);
 console.log('[Release Name] ' + releaseFullName);
 
@@ -161,4 +161,4 @@ https.get({
     });
   }).on('error', (e) => {
       throw e;
-  });
+  });

src/animation/customGraphicTransition.ts

@@ -223,13 +223,13 @@ export function applyLeaveTransition(
             // TODO Data index?
             const config = getElementAnimationConfig('update', el, elOption, animatableModel, 0);
             config.done = () => {
-                parent.remove(el);
+                parent && parent.remove(el);
                 onRemove && onRemove();
             };
             el.animateTo(leaveToProps, config);
         }
         else {
-            parent.remove(el);
+            parent && parent.remove(el);
             onRemove && onRemove();
         }
     }

src/chart/bar/BarSeries.ts

@@ -81,8 +81,6 @@ export interface BarSeriesOption
 
     showBackground?: boolean
 
-    startValue?: number
-
     backgroundStyle?: ItemStyleOption & {
         borderRadius?: number | number[]
     }
@@ -166,4 +164,4 @@ class BarSeriesModel extends BaseBarSeriesModel<BarSeriesOption> {
 
 }
 
-export default BarSeriesModel;
+export default BarSeriesModel;

src/chart/bar/BarView.ts

@@ -364,6 +364,14 @@ class BarView extends ChartView {
                     }
                 }
 
+                const roundCapChanged = el && (el.type === 'sector' && roundCap || el.type === 'sausage' && !roundCap);
+                if (roundCapChanged) {
+                    // roundCap changed, there is no way to use animation from a `sector` to a `sausage` shape,
+                    // so remove the old one and create a new shape
+                    el && removeElementWithFadeOut(el, seriesModel, oldIndex);
+                    el = null;
+                }
+
                 if (!el) {
                     el = elementCreator[coord.type](
                         seriesModel,
@@ -373,7 +381,7 @@ class BarView extends ChartView {
                         isHorizontalOrRadial,
                         animationModel,
                         baseAxis.model,
-                        !!el,
+                        true,
                         roundCap
                     );
                 }

src/chart/pie/PieView.ts

@@ -205,7 +205,7 @@ class PiePiece extends graphic.Sector {
             z2: 10
         });
 
-        const labelPosition = seriesModel.get(['label', 'position']);
+        const labelPosition = itemModel.get(['label', 'position']);
         if (labelPosition !== 'outside' && labelPosition !== 'outer') {
             sector.removeTextGuideLine();
         }

src/component/legend/LegendView.ts

@@ -236,11 +236,11 @@ class LegendView extends ComponentView {
                         ecData.ssrType = 'legend';
                     });
                 }
-                itemGroup.eachChild(child => {
-                    if (triggerEvent) {
+                if (triggerEvent) {
+                    itemGroup.eachChild(child => {
                         this.packEventData(child, legendModel, seriesModel, dataIndex, name);
-                    }
-                });
+                    });
+                }
 
                 legendDrawnMap.set(name, true);
             }
@@ -294,11 +294,11 @@ class LegendView extends ComponentView {
                                 ecData.ssrType = 'legend';
                             });
                         }
-                        itemGroup.eachChild(child => {
-                            if (triggerEvent) {
+                        if (triggerEvent) {
+                            itemGroup.eachChild(child => {
                                 this.packEventData(child, legendModel, seriesModel, dataIndex, name);
-                            }
-                        });
+                            });
+                        }
                         legendDrawnMap.set(name, true);
                     }
 

src/core/echarts.ts

@@ -767,10 +767,6 @@ class ECharts extends Eventful<ECEventDefinition> {
      * Get svg data url
      */
     getSvgDataURL(): string {
-        if (!env.svgSupported) {
-            return;
-        }
-
         const zr = this._zr;
         const list = zr.storage.getDisplayList();
         // Stop animations