From 5a1be948971b789d912376e51f0f474b7b6b553f Mon Sep 17 00:00:00 2001 From: Ovilia Date: Wed, 4 Dec 2024 18:29:28 +0800 Subject: [PATCH] refactor(pictorial): refactor xor logic --- src/chart/bar/PictorialBarView.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/chart/bar/PictorialBarView.ts b/src/chart/bar/PictorialBarView.ts index d834bffc0e..43e2da9d89 100644 --- a/src/chart/bar/PictorialBarView.ts +++ b/src/chart/bar/PictorialBarView.ts @@ -341,7 +341,9 @@ function prepareBarLength( // if 'pxSign' means sign of pixel, it can't be zero, or symbolScale will be zero // and when borderWidth be settled, the actual linewidth will be NaN - outputSymbolMeta.pxSign = (valueDim.xy === 'x' !== valueAxis.inverse) + const isXAxis = valueDim.xy === 'x'; + const isInverse = valueAxis.inverse; + outputSymbolMeta.pxSign = (isXAxis && !isInverse || !isXAxis && isInverse) ? boundingLength >= 0 ? 1 : -1 : boundingLength > 0 ? 1 : -1; }