Skip to content

Remove ParquetSource::pruning_predicate #15545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alamb opened this issue Apr 2, 2025 · 0 comments
Closed

Remove ParquetSource::pruning_predicate #15545

alamb opened this issue Apr 2, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Apr 2, 2025

Is your feature request related to a problem or challenge?

I suggest we change this code to always return None (and remove the page pruning predicate from the source).

Otherwise I predict that we'll end up with this field slowly bitrotting (aka stop working but not covered by tests)

ParquetSource::pruning_predicate is no longer used after #15301

Describe the solution you'd like

so we should remove the actual field (while leaving the deprecated methods)

Describe alternatives you've considered

No response

Additional context

No response

@alamb alamb added the enhancement New feature or request label Apr 2, 2025
@alamb alamb closed this as completed Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant