Skip to content

Datafusion-cli: when the max rows setting inf, we are missing the unlimited case for bounded streaming. #14814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhuqi-lucas opened this issue Feb 21, 2025 · 0 comments · Fixed by #14815
Labels
bug Something isn't working

Comments

@zhuqi-lucas
Copy link
Contributor

zhuqi-lucas commented Feb 21, 2025

Describe the bug

#14766

After above improvement, we improved the datafusion-cli memory usage and memory reservation, but we forgot one case:

When the max rows setting inf, we are missing the unlimited case for bounded streaming.

To Reproduce

/usr/bin/time -l cargo run --release --   -m 20G --mem-pool-type fair  --maxrows inf -f '/Users/zhuqi/arrow-datafusion/benchmarks/data/external_sort.sql'

The above will show nothing, because we are not adding unlimited case for bounded streaming to current buffer.

Expected behavior

We should support unlimited case, we can get all the result print.

Additional context

No response

@zhuqi-lucas zhuqi-lucas added the bug Something isn't working label Feb 21, 2025
@zhuqi-lucas zhuqi-lucas changed the title Datafusion-cli, when the max rows setting inf, we are missing the unlimited case for bounded streaming. Datafusion-cli: when the max rows setting inf, we are missing the unlimited case for bounded streaming. Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant