You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On the flip side I'm the only one currently that can automatically regenerate the slt files so someone doesn't have to manually fix a few hundred or few thousand test cases (I have hacked up code to do it with a hacked side-branch of the sqllogictest-rs repo to do the generation).
Describe the solution you'd like
I would like a documented way for someone other than @Omega359 to update the expected results :)
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered:
So I have a bit of an issue with this. I don't know how to implement this without pointing to a branch in my fork of sqllogictest-rs. The code in that branch is not appropriate for including in upstream - it's just a solution to this one single issue (getting sqlite tests to run in DF and complete them). Is that acceptable?
So I have a bit of an issue with this. I don't know how to implement this without pointing to a branch in my fork of sqllogictest-rs. The code in that branch is not appropriate for including in upstream - it's just a solution to this one single issue (getting sqlite tests to run in DF and complete them). Is that acceptable?
Well, it seems better than not being able to update the tests 😬
If /when it gets too painful to maintain perhaps we can evaluate an alternative?
Is your feature request related to a problem or challenge?
Now we have the sqlite test suite running against commits to main (see #13967) we need to make sure it the expected answers easy to update when needed
The first examples comes in #14156 (❤ @avkirilishin ) that fixes a bug so we need to update the sqlite expected results with the correct answer
As @Omega359 says on #14156 (comment) apparently this is hard to do
Describe the solution you'd like
I would like a documented way for someone other than @Omega359 to update the expected results :)
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: