Skip to content

Move StringArrayType, StringViewArrayBuilder, StringArrayBuilder & LargeStringArrayBuilder from functions/string/common.rs to a more common crate/module #12898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Omega359 opened this issue Oct 12, 2024 · 3 comments · Fixed by #12912
Closed

Move StringArrayType, StringViewArrayBuilder, StringArrayBuilder & LargeStringArrayBuilder from functions/string/common.rs to a more common crate/module #12898

Omega359 opened this issue Oct 12, 2024 · 3 comments · Fixed by #12912
Assignees
@Omega359
Labels
enhancement New feature or request

Comments

@Omega359
Copy link
Contributor

Is your feature request related to a problem or challenge?

Currently the StringArrayType trait and the String*Builder structs are in the string crate however these are used in other crates (unicode, soon to include regex) and thus should be moved out to a more common location to not introduce needless dependencies between function crates.

Describe the solution you'd like

My first thought is to create a functions/string_common.rs file and move the above mentioned trait and structs to this file, update all code, remove crate dependencies and update any tests as required.

Describe alternatives you've considered

Leave things alone and allow the crate dependencies to stay.

Additional context

No response
@Omega359 Omega359 added the enhancement New feature or request label Oct 12, 2024
@Omega359
Copy link
Contributor Author

Related to #12080

@tlm365
Copy link
Contributor

tlm365 commented Oct 12, 2024

I haven't checked the others thoroughly, but with StringArrayType I believe we can remove it now and reuse it from arrow-rs here

@Omega359
Copy link
Contributor Author

take

@Omega359 Omega359 mentioned this issue Oct 13, 2024
Merged
Omega359 added a commit to Omega359/arrow-datafusion that referenced this issue Oct 15, 2024
@Omega359
datetime depends on string expressions until apache#12898 lands
83baa10
alamb added a commit that referenced this issue Oct 16, 2024
@Omega359 @alamb
Update TO_DATE, TO_TIMESTAMP scalar functions to support LargeUtf8, U…
435f959 
…tf8View (#12929)

* Update to_date and to_timestamp* udfs to support largeutf8 and utf8view. Benchmark updated as well

* datetime depends on string expressions until #12898 lands

* update to reflect the stringarraytype move to a common path

* Update datafusion/functions/src/datetime/common.rs

---------

Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Omega359 Omega359

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@Omega359 @tlm365