Skip to content

Commit 8c6bb39

Browse files
authored
fix: import JoinTestType without triggering unused_qualifications lint (#13170)
* fix: import JoinTestType without triggering unused_qualifications lint * fix: remove use statement instead of removing qualifications
1 parent 68bf7ad commit 8c6bb39

File tree

1 file changed

+1
-15
lines changed

1 file changed

+1
-15
lines changed

datafusion/core/tests/fuzz_cases/join_fuzz.rs

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ use datafusion::physical_plan::joins::{
4141
};
4242
use datafusion::physical_plan::memory::MemoryExec;
4343

44-
use crate::fuzz_cases::join_fuzz::JoinTestType::NljHj;
4544
use datafusion::prelude::{SessionConfig, SessionContext};
4645
use test_utils::stagger_batch_with_seed;
4746

@@ -90,7 +89,6 @@ fn col_lt_col_filter(schema1: Arc<Schema>, schema2: Arc<Schema>) -> JoinFilter {
9089
}
9190

9291
#[tokio::test]
93-
#[allow(unused_qualifications)]
9492
async fn test_inner_join_1k_filtered() {
9593
JoinFuzzTestCase::new(
9694
make_staggered_batches(1000),
@@ -103,7 +101,6 @@ async fn test_inner_join_1k_filtered() {
103101
}
104102

105103
#[tokio::test]
106-
#[allow(unused_qualifications)]
107104
async fn test_inner_join_1k() {
108105
JoinFuzzTestCase::new(
109106
make_staggered_batches(1000),
@@ -116,7 +113,6 @@ async fn test_inner_join_1k() {
116113
}
117114

118115
#[tokio::test]
119-
#[allow(unused_qualifications)]
120116
async fn test_left_join_1k() {
121117
JoinFuzzTestCase::new(
122118
make_staggered_batches(1000),
@@ -129,7 +125,6 @@ async fn test_left_join_1k() {
129125
}
130126

131127
#[tokio::test]
132-
#[allow(unused_qualifications)]
133128
async fn test_left_join_1k_filtered() {
134129
JoinFuzzTestCase::new(
135130
make_staggered_batches(1000),
@@ -142,7 +137,6 @@ async fn test_left_join_1k_filtered() {
142137
}
143138

144139
#[tokio::test]
145-
#[allow(unused_qualifications)]
146140
async fn test_right_join_1k() {
147141
JoinFuzzTestCase::new(
148142
make_staggered_batches(1000),
@@ -155,7 +149,6 @@ async fn test_right_join_1k() {
155149
}
156150

157151
#[tokio::test]
158-
#[allow(unused_qualifications)]
159152
async fn test_right_join_1k_filtered() {
160153
JoinFuzzTestCase::new(
161154
make_staggered_batches(1000),
@@ -168,7 +161,6 @@ async fn test_right_join_1k_filtered() {
168161
}
169162

170163
#[tokio::test]
171-
#[allow(unused_qualifications)]
172164
async fn test_full_join_1k() {
173165
JoinFuzzTestCase::new(
174166
make_staggered_batches(1000),
@@ -181,7 +173,6 @@ async fn test_full_join_1k() {
181173
}
182174

183175
#[tokio::test]
184-
#[allow(unused_qualifications)]
185176
// flaky for HjSmj case
186177
// https://github.com/apache/datafusion/issues/12359
187178
async fn test_full_join_1k_filtered() {
@@ -196,7 +187,6 @@ async fn test_full_join_1k_filtered() {
196187
}
197188

198189
#[tokio::test]
199-
#[allow(unused_qualifications)]
200190
async fn test_semi_join_1k() {
201191
JoinFuzzTestCase::new(
202192
make_staggered_batches(1000),
@@ -209,7 +199,6 @@ async fn test_semi_join_1k() {
209199
}
210200

211201
#[tokio::test]
212-
#[allow(unused_qualifications)]
213202
async fn test_semi_join_1k_filtered() {
214203
JoinFuzzTestCase::new(
215204
make_staggered_batches(1000),
@@ -222,7 +211,6 @@ async fn test_semi_join_1k_filtered() {
222211
}
223212

224213
#[tokio::test]
225-
#[allow(unused_qualifications)]
226214
async fn test_anti_join_1k() {
227215
JoinFuzzTestCase::new(
228216
make_staggered_batches(1000),
@@ -235,15 +223,14 @@ async fn test_anti_join_1k() {
235223
}
236224

237225
#[tokio::test]
238-
#[allow(unused_qualifications)]
239226
async fn test_anti_join_1k_filtered() {
240227
JoinFuzzTestCase::new(
241228
make_staggered_batches(1000),
242229
make_staggered_batches(1000),
243230
JoinType::LeftAnti,
244231
Some(Box::new(col_lt_col_filter)),
245232
)
246-
.run_test(&[JoinTestType::HjSmj, NljHj], false)
233+
.run_test(&[JoinTestType::HjSmj, JoinTestType::NljHj], false)
247234
.await
248235
}
249236

@@ -461,7 +448,6 @@ impl JoinFuzzTestCase {
461448
/// `join_tests` - identifies what join types to test
462449
/// if `debug` flag is set the test will save randomly generated inputs and outputs to user folders,
463450
/// so it is easy to debug a test on top of the failed data
464-
#[allow(unused_qualifications)]
465451
async fn run_test(&self, join_tests: &[JoinTestType], debug: bool) {
466452
for batch_size in self.batch_sizes {
467453
let session_config = SessionConfig::new().with_batch_size(*batch_size);

0 commit comments

Comments
 (0)