Skip to content

Commit 8162cbc

Browse files
committed
remove unused param.
1 parent db8e576 commit 8162cbc

File tree

1 file changed

+9
-64
lines changed

1 file changed

+9
-64
lines changed

datafusion/functions/benches/ltrim.rs

Lines changed: 9 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ pub fn create_string_array_and_characters(
8686
///
8787
fn create_args(
8888
size: usize,
89-
characters: &str,
9089
trimmed: &str,
9190
remaining_len: usize,
9291
string_array_type: StringArrayType,
@@ -117,13 +116,7 @@ fn criterion_benchmark(c: &mut Criterion) {
117116
group.sampling_mode(SamplingMode::Flat);
118117
group.sample_size(10);
119118

120-
let args = create_args(
121-
size,
122-
&characters,
123-
&trimmed,
124-
remaining_len,
125-
StringArrayType::Utf8View,
126-
);
119+
let args = create_args(size, &trimmed, remaining_len, StringArrayType::Utf8View);
127120
group.bench_function(
128121
format!(
129122
"ltrim_string_view [size={}, len_before_ltrim={}, len_after_ltrim={}]",
@@ -132,13 +125,7 @@ fn criterion_benchmark(c: &mut Criterion) {
132125
|b| b.iter(|| black_box(ltrim.invoke(&args))),
133126
);
134127

135-
let args = create_args(
136-
size,
137-
&characters,
138-
&trimmed,
139-
remaining_len,
140-
StringArrayType::Utf8,
141-
);
128+
let args = create_args(size, &trimmed, remaining_len, StringArrayType::Utf8);
142129
group.bench_function(
143130
format!(
144131
"ltrim_string [size={}, len_before_ltrim={}, len_after_ltrim={}]",
@@ -147,13 +134,7 @@ fn criterion_benchmark(c: &mut Criterion) {
147134
|b| b.iter(|| black_box(ltrim.invoke(&args))),
148135
);
149136

150-
let args = create_args(
151-
size,
152-
&characters,
153-
&trimmed,
154-
remaining_len,
155-
StringArrayType::LargeUtf8,
156-
);
137+
let args = create_args(size, &trimmed, remaining_len, StringArrayType::LargeUtf8);
157138
group.bench_function(
158139
format!(
159140
"ltrim_large_string [size={}, len_before_ltrim={}, len_after_ltrim={}]",
@@ -172,13 +153,7 @@ fn criterion_benchmark(c: &mut Criterion) {
172153
group.sampling_mode(SamplingMode::Flat);
173154
group.sample_size(10);
174155

175-
let args = create_args(
176-
size,
177-
&characters,
178-
&trimmed,
179-
remaining_len,
180-
StringArrayType::Utf8View,
181-
);
156+
let args = create_args(size, &trimmed, remaining_len, StringArrayType::Utf8View);
182157
group.bench_function(
183158
format!(
184159
"ltrim_string_view [size={}, len_before_ltrim={}, len_after_ltrim={}]",
@@ -187,13 +162,7 @@ fn criterion_benchmark(c: &mut Criterion) {
187162
|b| b.iter(|| black_box(ltrim.invoke(&args))),
188163
);
189164

190-
let args = create_args(
191-
size,
192-
&characters,
193-
&trimmed,
194-
remaining_len,
195-
StringArrayType::Utf8,
196-
);
165+
let args = create_args(size, &trimmed, remaining_len, StringArrayType::Utf8);
197166
group.bench_function(
198167
format!(
199168
"ltrim_string [size={}, len_before_ltrim={}, len_after_ltrim={}]",
@@ -202,13 +171,7 @@ fn criterion_benchmark(c: &mut Criterion) {
202171
|b| b.iter(|| black_box(ltrim.invoke(&args))),
203172
);
204173

205-
let args = create_args(
206-
size,
207-
&characters,
208-
&trimmed,
209-
remaining_len,
210-
StringArrayType::LargeUtf8,
211-
);
174+
let args = create_args(size, &trimmed, remaining_len, StringArrayType::LargeUtf8);
212175
group.bench_function(
213176
format!(
214177
"ltrim_large_string [size={}, len_before_ltrim={}, len_after_ltrim={}]",
@@ -227,13 +190,7 @@ fn criterion_benchmark(c: &mut Criterion) {
227190
group.sampling_mode(SamplingMode::Flat);
228191
group.sample_size(10);
229192

230-
let args = create_args(
231-
size,
232-
&characters,
233-
&trimmed,
234-
remaining_len,
235-
StringArrayType::Utf8View,
236-
);
193+
let args = create_args(size, &trimmed, remaining_len, StringArrayType::Utf8View);
237194
group.bench_function(
238195
format!(
239196
"ltrim_string_view [size={}, len_before_ltrim={}, len_after_ltrim={}]",
@@ -242,13 +199,7 @@ fn criterion_benchmark(c: &mut Criterion) {
242199
|b| b.iter(|| black_box(ltrim.invoke(&args))),
243200
);
244201

245-
let args = create_args(
246-
size,
247-
&characters,
248-
&trimmed,
249-
remaining_len,
250-
StringArrayType::Utf8,
251-
);
202+
let args = create_args(size, &trimmed, remaining_len, StringArrayType::Utf8);
252203
group.bench_function(
253204
format!(
254205
"ltrim_string [size={}, len_before_ltrim={}, len_after_ltrim={}]",
@@ -257,13 +208,7 @@ fn criterion_benchmark(c: &mut Criterion) {
257208
|b| b.iter(|| black_box(ltrim.invoke(&args))),
258209
);
259210

260-
let args = create_args(
261-
size,
262-
&characters,
263-
&trimmed,
264-
remaining_len,
265-
StringArrayType::LargeUtf8,
266-
);
211+
let args = create_args(size, &trimmed, remaining_len, StringArrayType::LargeUtf8);
267212
group.bench_function(
268213
format!(
269214
"ltrim_large_string [size={}, len_before_ltrim={}, len_after_ltrim={}]",

0 commit comments

Comments
 (0)