resolve comment

Author: Kikkon

datafusion/proto/src/common.rs

@@ -17,7 +17,7 @@
 
 use datafusion_common::DataFusionError;
 
-pub fn byte_to_string(b: u8) -> Result<String, DataFusionError> {
+pub fn csv_delimiter_to_string(b: u8) -> Result<String, DataFusionError> {
     let b = &[b];
     let b = std::str::from_utf8(b)
         .map_err(|_| DataFusionError::Internal("Invalid CSV delimiter".to_owned()))?;

datafusion/proto/src/physical_plan/from_proto.rs

@@ -96,17 +96,17 @@ pub(crate) fn parse_physical_expr(
             input_schema,
         )?),
         ExprType::AggregateExpr(_) => {
-            return Err(DataFusionError::Internal(
+            return Err(DataFusionError::NotImplemented(
                 "Cannot convert aggregate expr node to physical expression".to_owned(),
             ));
         }
         ExprType::WindowExpr(_) => {
-            return Err(DataFusionError::Internal(
+            return Err(DataFusionError::NotImplemented(
                 "Cannot convert window expr node to physical expression".to_owned(),
             ));
         }
         ExprType::Sort(_) => {
-            return Err(DataFusionError::Internal(
+            return Err(DataFusionError::NotImplemented(
                 "Cannot convert sort expr node to physical expression".to_owned(),
             ));
         }

datafusion/proto/src/physical_plan/mod.rs

@@ -58,7 +58,7 @@ use prost::bytes::BufMut;
 use prost::Message;
 
 use crate::common::proto_error;
-use crate::common::{byte_to_string, str_to_byte};
+use crate::common::{csv_delimiter_to_string, str_to_byte};
 use crate::from_proto::parse_expr;
 use crate::physical_plan::from_proto::parse_physical_expr;
 use crate::protobuf::physical_expr_node::ExprType;
@@ -946,7 +946,7 @@ impl AsExecutionPlan for PhysicalPlanNode {
                     protobuf::CsvScanExecNode {
                         base_conf: Some(exec.base_config().try_into()?),
                         has_header: exec.has_header(),
-                        delimiter: byte_to_string(exec.delimiter())?,
+                        delimiter: csv_delimiter_to_string(exec.delimiter())?,
                     },
                 )),
             })