Skip to content

Commit 749cd6f

Browse files
authored
Report current function name when invoke result length wrong (#13643)
This makes for a more actionable error message.
1 parent e5422de commit 749cd6f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

datafusion/core/tests/user_defined/user_defined_scalar_functions.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ async fn test_row_mismatch_error_in_scalar_udf() -> Result<()> {
251251
.err()
252252
.unwrap()
253253
.to_string(),
254-
"UDF returned a different number of rows than expected"
254+
"Internal error: UDF buggy_func returned a different number of rows than expected. Expected: 2, Got: 1"
255255
);
256256
Ok(())
257257
}

datafusion/physical-expr/src/scalar_function.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,8 @@ impl PhysicalExpr for ScalarFunctionExpr {
161161
return if preserve_scalar {
162162
ScalarValue::try_from_array(array, 0).map(ColumnarValue::Scalar)
163163
} else {
164-
internal_err!("UDF returned a different number of rows than expected. Expected: {}, Got: {}",
165-
batch.num_rows(), array.len())
164+
internal_err!("UDF {} returned a different number of rows than expected. Expected: {}, Got: {}",
165+
self.name, batch.num_rows(), array.len())
166166
};
167167
}
168168
}

0 commit comments

Comments
 (0)