Skip to content

Commit 3d13091

Browse files
authored
Enable TTY during bench data gen (#9626)
1 parent 00a1225 commit 3d13091

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

.github/workflows/pr_benchmarks.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ jobs:
2222
ref: refs/pull/${{ github.event.issue.number }}/head
2323

2424
- name: Setup data and generate unique result names
25+
# Workaround for `the input device is not a TTY`, appropriated from https://github.com/actions/runner/issues/241
26+
shell: 'script -q -e -c "bash -e {0}"'
2527
run: |
2628
cd benchmarks
2729
mkdir data

benchmarks/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,8 @@ Benchmark tpch_mem.json
150150
└──────────────┴──────────────┴──────────────┴───────────────┘
151151
```
152152

153+
Note that you can also execute an automatic comparison of the changes in a given PR against the base
154+
just by including the trigger `/benchmark` in any comment.
153155

154156
### Running Benchmarks Manually
155157

benchmarks/bench.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ data_tpch() {
280280
echo " tbl files exist ($FILE exists)."
281281
else
282282
echo " creating tbl files with tpch_dbgen..."
283-
docker run -v "${TPCH_DIR}":/data --rm ghcr.io/scalytics/tpch-docker:main -vf -s ${SCALE_FACTOR}
283+
docker run -v "${TPCH_DIR}":/data -it --rm ghcr.io/scalytics/tpch-docker:main -vf -s ${SCALE_FACTOR}
284284
fi
285285

286286
# Copy expected answers into the ./data/answers directory if it does not already exist
@@ -290,7 +290,7 @@ data_tpch() {
290290
else
291291
echo " Copying answers to ${TPCH_DIR}/answers"
292292
mkdir -p "${TPCH_DIR}/answers"
293-
docker run -v "${TPCH_DIR}":/data --entrypoint /bin/bash --rm ghcr.io/scalytics/tpch-docker:main -c "cp -f /opt/tpch/2.18.0_rc2/dbgen/answers/* /data/answers/"
293+
docker run -v "${TPCH_DIR}":/data -it --entrypoint /bin/bash --rm ghcr.io/scalytics/tpch-docker:main -c "cp -f /opt/tpch/2.18.0_rc2/dbgen/answers/* /data/answers/"
294294
fi
295295

296296
# Create 'parquet' files from tbl

0 commit comments

Comments
 (0)