Skip to content

Commit 39877e4

Browse files
committed
avoid clone in replace_sort_expressions
1 parent cc6e991 commit 39877e4

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

datafusion/expr/src/tree_node.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -404,11 +404,11 @@ pub fn transform_sort_vec<F: FnMut(Expr) -> Result<Transformed<Expr>>>(
404404

405405
pub fn replace_sort_expressions(sorts: Vec<Sort>, new_expr: Vec<Expr>) -> Vec<Sort> {
406406
assert_eq!(sorts.len(), new_expr.len());
407-
let mut new_sorts = Vec::with_capacity(sorts.len());
408-
for (i, expr) in new_expr.into_iter().enumerate() {
409-
new_sorts.push(replace_sort_expression(sorts[i].clone(), expr));
410-
}
411-
new_sorts
407+
sorts
408+
.into_iter()
409+
.zip(new_expr)
410+
.map(|(sort, expr)| replace_sort_expression(sort, expr))
411+
.collect()
412412
}
413413

414414
pub fn replace_sort_expression(sort: Sort, new_expr: Expr) -> Sort {

0 commit comments

Comments
 (0)