clippy

Author: comphead

datafusion/common/src/column.rs

@@ -428,7 +428,7 @@ mod tests {
             )
             .expect_err("should've failed to find field");
         let expected = r#"Schema error: No field named z. Valid fields are t1.a, t1.b, t2.c, t2.d, t3.a, t3.b, t3.c, t3.d, t3.e."#;
-        assert!(err.to_string().start_with(expected));
+        assert!(err.to_string().starts_with(expected));
 
         // ambiguous column reference
         let col = Column::from_name("a");
@@ -439,7 +439,7 @@ mod tests {
             )
             .expect_err("should've found ambiguous field");
         let expected = "Schema error: Ambiguous reference to unqualified field a";
-        assert!(err.to_string().start_with(expected));
+        assert!(err.to_string().starts_with(expected));
 
         Ok(())
     }

datafusion/common/src/dfschema.rs

@@ -914,10 +914,9 @@ mod tests {
         let left = DFSchema::try_from(test_schema_1())?;
         let right = DFSchema::try_from(test_schema_1())?;
         let join = left.join(&right);
-        assert!(
-            join.unwrap_err().to_string().starts_with(,
-            "Schema error: Schema contains duplicate unqualified field name c0")
-        );
+        assert!(join.unwrap_err().to_string().starts_with(
+            "Schema error: Schema contains duplicate unqualified field name c0"
+        ));
         Ok(())
     }
 

datafusion/common/src/error.rs

@@ -507,17 +507,15 @@ mod test {
     #[test]
     fn arrow_error_to_datafusion() {
         let res = return_arrow_error().unwrap_err();
-        assert!(
-            res.to_string().starts_with(,
-            "External error: Error during planning: foo")
-        );
+        assert!(res
+            .to_string()
+            .starts_with("External error: Error during planning: foo"));
     }
 
     #[test]
     fn datafusion_error_to_arrow() {
         let res = return_datafusion_error().unwrap_err();
-        assert_eq!(res
-            .to_string()
+        assert!(res
             .to_string()
             .starts_with("Arrow error: Schema error: bar"));
     }
@@ -631,7 +629,7 @@ mod test {
         let e = e.find_root();
 
         // DataFusionError does not implement Eq, so we use a string comparison + some cheap "same variant" test instead
-        assert!(e.to_string().starts_with(exp.to_string()));
+        assert!(e.to_string().starts_with(&exp.to_string()));
         assert_eq!(std::mem::discriminant(e), std::mem::discriminant(&exp),)
     }
 }

datafusion/common/src/scalar.rs

@@ -3239,10 +3239,9 @@ mod tests {
         let int_value = ScalarValue::Int32(Some(i32::MAX));
         let int_value_2 = ScalarValue::Int32(Some(i32::MIN));
         let err = int_value.sub_checked(&int_value_2).unwrap_err().to_string();
-        assert!(
-            err.starts_with(,
-            "Arrow error: Compute error: Overflow happened on: 2147483647 - -2147483648")
-        )
+        assert!(err.starts_with(
+            "Arrow error: Compute error: Overflow happened on: 2147483647 - -2147483648"
+        ))
     }
 
     #[test]