Skip to content

Commit 11d49b4

Browse files
authored
feat(substrait): remove dependency on datafusion default features (#13594)
* feat(substrait): remove dependency on datafusion default features * ci(substrait): check without default features
1 parent 049ca15 commit 11d49b4

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

.github/workflows/rust.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,12 @@ jobs:
8080
- name: Check datafusion-common without default features
8181
run: cargo check --all-targets --no-default-features -p datafusion-common
8282

83-
- name: Check datafusion-functions
83+
- name: Check datafusion-functions without default features
8484
run: cargo check --all-targets --no-default-features -p datafusion-functions
8585

86+
- name: Check datafusion-substrait without default features
87+
run: cargo check --all-targets --no-default-features -p datafusion-substrait
88+
8689
- name: Check workspace in debug mode
8790
run: cargo check --all-targets --workspace
8891

@@ -603,4 +606,4 @@ jobs:
603606
run: cargo msrv --output-format json --log-target stdout verify
604607
- name: Check datafusion-cli
605608
working-directory: datafusion-cli
606-
run: cargo msrv --output-format json --log-target stdout verify
609+
run: cargo msrv --output-format json --log-target stdout verify

datafusion/substrait/Cargo.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ arrow-buffer = { workspace = true }
3636
async-recursion = "1.0"
3737
async-trait = { workspace = true }
3838
chrono = { workspace = true }
39-
datafusion = { workspace = true, default-features = true }
39+
datafusion = { workspace = true }
4040
itertools = { workspace = true }
4141
object_store = { workspace = true }
4242
pbjson-types = "0.7"
@@ -51,4 +51,6 @@ serde_json = "1.0"
5151
tokio = { workspace = true }
5252

5353
[features]
54+
default = ["physical"]
55+
physical = ["datafusion/parquet"]
5456
protoc = ["substrait/protoc"]

datafusion/substrait/src/lib.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@
7575
//! ```
7676
pub mod extensions;
7777
pub mod logical_plan;
78+
#[cfg(feature = "physical")]
7879
pub mod physical_plan;
7980
pub mod serializer;
8081
pub mod variation_const;

datafusion/substrait/tests/cases/mod.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ mod emit_kind_tests;
2020
mod function_test;
2121
mod logical_plans;
2222
mod roundtrip_logical_plan;
23+
#[cfg(feature = "physical")]
2324
mod roundtrip_physical_plan;
2425
mod serialize;
2526
mod substrait_validations;

0 commit comments

Comments
 (0)