Add HAVING as a reserved work for column/table aliases

The ANSI spec allows eg `SELECT 1 HAVING true` or `SELECT * FROM foo HAVING true`

Author: jamii

src/dialect/keywords.rs

@@ -426,7 +426,7 @@ define_keywords!(
 /// can be parsed unambiguously without looking ahead.
 pub const RESERVED_FOR_TABLE_ALIAS: &[&str] = &[
     // Reserved as both a table and a column alias:
-    WITH, SELECT, WHERE, GROUP, ORDER, UNION, EXCEPT, INTERSECT,
+    WITH, SELECT, WHERE, GROUP, ORDER, UNION, EXCEPT, INTERSECT, HAVING,
     // Reserved only as a table alias in the `FROM`/`JOIN` clauses:
     ON, JOIN, INNER, CROSS, FULL, LEFT, RIGHT, NATURAL, USING, LIMIT, OFFSET, FETCH,
 ];
@@ -435,7 +435,7 @@ pub const RESERVED_FOR_TABLE_ALIAS: &[&str] = &[
 /// can be parsed unambiguously without looking ahead.
 pub const RESERVED_FOR_COLUMN_ALIAS: &[&str] = &[
     // Reserved as both a table and a column alias:
-    WITH, SELECT, WHERE, GROUP, ORDER, UNION, EXCEPT, INTERSECT,
+    WITH, SELECT, WHERE, GROUP, ORDER, UNION, EXCEPT, INTERSECT, HAVING,
     // Reserved only as a column alias in the `SELECT` clause:
     FROM,
 ];

tests/sqlparser_common.rs

@@ -1155,6 +1155,21 @@ fn parse_aggregate_with_group_by() {
     //TODO: assertions
 }
 
+#[test]
+fn parse_having() {
+    let sql = "SELECT 1 HAVING true";
+    let ast = verified_only_select(sql);
+    assert_eq!(&Some(ASTNode::SQLValue(Value::Boolean(true))), &ast.having);
+
+    let sql = "SELECT a FROM foo HAVING true";
+    let ast = verified_only_select(sql);
+    assert_eq!(&Some(ASTNode::SQLValue(Value::Boolean(true))), &ast.having);
+
+    let sql = "SELECT a FROM foo GROUP BY a, b HAVING true";
+    let ast = verified_only_select(sql);
+    assert_eq!(&Some(ASTNode::SQLValue(Value::Boolean(true))), &ast.having);
+}
+
 #[test]
 fn parse_literal_string() {
     let sql = "SELECT 'one', N'national string', X'deadBEEF'";