Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for generating JSON formatted substrait plan #508

Open
richtia opened this issue Oct 4, 2023 · 8 comments
Open

Support for generating JSON formatted substrait plan #508

richtia opened this issue Oct 4, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@richtia
Copy link
Contributor

richtia commented Oct 4, 2023

A few other substrait producers are able to generate a JSON formatted substrait plan (Isthmus, DuckDB). It would be nice if datafusion could do this as well. It would make it much easier to compare the generated substrait plans.

@richtia richtia added the enhancement New feature or request label Oct 4, 2023
@EpsilonPrime
Copy link

One alternative would to be to use the protobuf json_format package to export/import the JSON.

@mbrobbel
Copy link
Member

mbrobbel commented Apr 5, 2024

The substrait crate supports the Protobuf JSON Mapping via the serde feature: https://docs.rs/substrait/latest/substrait/#serde-support.

@timsaucer timsaucer added the good first issue Good for newcomers label Nov 5, 2024
@swayam0322
Copy link

Is this issue up for grabs?

@kosiew
Copy link
Contributor

kosiew commented Mar 14, 2025

@swayam0322 ,

You can add a new comment
take
to assign yourself this issue.

@swayam0322
Copy link

take

@kosiew
Copy link
Contributor

kosiew commented Mar 15, 2025

hmm...
Strange that github actions did not trigger:

Image

@timsaucer
Copy link
Contributor

I'm not sure why the job was skipped: https://github.com/apache/datafusion-python/actions/runs/13870548324/job/38816616372

I assigned it though

@Vabs-108
Copy link

is the issue still coming. Do anyone wants me to resolve the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

7 participants