Skip to content

Commit 4cf46c3

Browse files
committed
prepare for review
1 parent e230275 commit 4cf46c3

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1146,10 +1146,7 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper {
11461146
}
11471147
}
11481148

1149-
// TODO: test currently fails with
1150-
// Unsupported Data Type: Spark `expm1` function expects Float64, got Utf8
11511149
test("expm1") {
1152-
// TODO test with null inputs
11531150
val testValues = Seq(
11541151
-1,
11551152
0,

spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,6 @@ abstract class CometTestBase
111111
actualAnswer: Row,
112112
expectedAnswer: Row,
113113
absTol: Double): Unit = {
114-
// scalastyle:off println
115-
println(s"actual=$actualAnswer, expected=$expectedAnswer")
116114
require(
117115
actualAnswer.length == expectedAnswer.length,
118116
s"actual answer length ${actualAnswer.length} != " +
@@ -122,8 +120,7 @@ abstract class CometTestBase
122120
actualAnswer.toSeq.zip(expectedAnswer.toSeq).foreach {
123121
case (actual: Double, expected: Double) =>
124122
if (actual.isInfinity || expected.isInfinity) {
125-
assert(actual.isInfinity == expected.isInfinity,
126-
s"actual answer $actual != $expected")
123+
assert(actual.isInfinity == expected.isInfinity, s"actual answer $actual != $expected")
127124
} else if (!actual.isNaN && !expected.isNaN) {
128125
assert(
129126
math.abs(actual - expected) < absTol,

0 commit comments

Comments
 (0)