vmware: interface for additional public IP in VR is not unplugged when public IP is released

[weizhouapache]

step to reproduce the issue

(1) create isolated network
(2) add new public ip range
(3) acquire public ip in new ip range
(4) create port forwarding rule. a new NIC is added to the network VR
(5) releae the public ip.

expected result (this is actual result in kvm/xenserver env):
new NIC is removed in network VR

actual result (in vmware env):
IP is unassigned, but NIC is not removed

related code:

(vmware)

cloudstack/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java

Lines 1102 to 1105 in 194bf6e

	@Override
	public ExecutionResult cleanupCommand(NetworkElementCommand cmd) {
	return new ExecutionResult(true, null);
	}

(kvm)

cloudstack/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

Lines 490 to 496 in 194bf6e

	@Override
	public ExecutionResult cleanupCommand(final NetworkElementCommand cmd) {
	if (cmd instanceof IpAssocCommand && !(cmd instanceof IpAssocVpcCommand)) {
	return cleanupNetworkElementCommand((IpAssocCommand)cmd);
	}
	return new ExecutionResult(true, null);
	}

(xenserver)

cloudstack/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java

Lines 590 to 596 in 194bf6e

	@Override
	public ExecutionResult cleanupCommand(final NetworkElementCommand cmd) {
	if (cmd instanceof IpAssocCommand && !(cmd instanceof IpAssocVpcCommand)) {
	return cleanupNetworkElementCommand((IpAssocCommand)cmd);
	}
	return new ExecutionResult(true, null);
	}

ISSUE TYPE

• Bug Report

COMPONENT NAME

VR

CLOUDSTACK VERSION

4.16/main

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS