improve logging in vmware storage processor

[DaanHoogland]

VolumeOrchestrator gives a cryptic message when copy from primary to secondary failes on Vmware during migrate volume.

Failed to migrate volumecom.cloud.exception.StorageUnavailableException: Resource [StoragePool:1446] is unreachable: Migrate volume failed: copy volume from primary to secondary failed due to exception: Exception: java.lang.NullPointerExceptionMessage: null

there is a lot of information in the message about where things went wrong but not about what is wrong. The NPE is not locatable from the message or the accompanyting stacktrace.

in com.cloud.storage.resource.VmwareStorageProcessor#copyVolumeFromPrimaryToSecondary , diagnostic output should be improved.

ISSUE TYPE

• Improvement Request

COMPONENT NAME

Vmware Storage

CLOUDSTACK VERSION

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

[DaanHoogland]

@nvazquez @harikrishna-patnala you did a lot of refactoring on vmware lately, Did you encounter this as well and do you have any opinion on how to improve?

[DaanHoogland]

marking this as minor as no-one really complains about it, or is giving it any attention.

[nvazquez]

@DaanHoogland PR #5353 improves that specific class, think it is good or needs further logging improvement?

[DaanHoogland]

#5353 looks promissing, I think we'll need to get further requirements from practical use after it had been merged, @nvazquez . let's consider that one closing this.

[DaanHoogland]

@nvazquez do you dare to merge 5353 in before 4.16?

[nvazquez]

No @DaanHoogland, the PR has been recently fixed as there were many smoke tests failures so will need further review and tests