Adjusts logs

GutoVeronezi · GutoVeronezi · commit a8dc74817f05 · 2025-12-14T23:56:00.000-03:00
diff --git a/api/src/main/java/com/cloud/agent/api/storage/OVFHelper.java b/api/src/main/java/com/cloud/agent/api/storage/OVFHelper.java
@@ -501,7 +501,7 @@ private void writeDocumentToFile(String newOvfFilePath, Document doc) {
             outfile.write(writer.toString());
             outfile.close();
         } catch (IOException | TransformerException e) {
-            logger.info("Unexpected exception caught while rewriting OVF:{}", e.getMessage(), e);
+            logger.info("Unexpected exception caught while rewriting OVF: {}", e.getMessage(), e);
             throw new CloudRuntimeException(e);
         }
     }
@@ -767,7 +767,7 @@ private Integer getIntValueFromString(String value) {
             try {
                 return Integer.parseInt(value);
             } catch (NumberFormatException e) {
-                logger.debug("Could not parse the value: {} ignoring it", value);
+                logger.debug("Could not parse the value: {}, ignoring it", value);
             }
         }
         return null;
diff --git a/api/src/main/java/org/apache/cloudstack/api/command/admin/host/UpdateHostCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/admin/host/UpdateHostCmd.java
@@ -147,7 +147,7 @@ public void execute() {
             this.setResponseObject(hostResponse);
         } catch (Exception e) {
             Host host = _entityMgr.findById(Host.class, getId());
-            logger.debug("Failed to update host: {} with id {}", host, getId(), e);
+            logger.debug("Failed to update {}", host, e);
             throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, String.format("Failed to update host: %s with id %d, %s", host, getId(), e.getMessage()));
         }
     }
diff --git a/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/CreateVlanIpRangeCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/CreateVlanIpRangeCmd.java
@@ -237,7 +237,7 @@ public void execute() throws ResourceUnavailableException, ResourceAllocationExc
             logger.warn("Exception: ", ex);
             throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, ex.getMessage());
         } catch (InsufficientCapacityException ex) {
-            logger.info(ex);
+            logger.error(ex);
             throw new ServerApiException(ApiErrorCode.INSUFFICIENT_CAPACITY_ERROR, ex.getMessage());
         }
     }
diff --git a/api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ImportUnmanagedInstanceCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ImportUnmanagedInstanceCmd.java
@@ -201,7 +201,7 @@ public Map<String, Long> getNicNetworkList() {
             for (Map<String, String> entry : (Collection<Map<String, String>>)nicNetworkList.values()) {
                 String nic = entry.get(VmDetailConstants.NIC);
                 String networkUuid = entry.get(VmDetailConstants.NETWORK);
-                logger.debug("nic, '{}', goes on net, '{}'", nic, networkUuid);
+                logger.debug("Checking if NIC '{}' can be mapped on network '{}'", nic, networkUuid);
                 if (StringUtils.isAnyEmpty(nic, networkUuid) || _entityMgr.findByUuid(Network.class, networkUuid) == null) {
                     throw new InvalidParameterValueException(String.format("Network ID: %s for NIC ID: %s is invalid", networkUuid, nic));
                 }
@@ -217,7 +217,7 @@ public Map<String, Network.IpAddresses> getNicIpAddressList() {
             for (Map<String, String> entry : (Collection<Map<String, String>>)nicIpAddressList.values()) {
                 String nic = entry.get(VmDetailConstants.NIC);
                 String ipAddress = StringUtils.defaultIfEmpty(entry.get(VmDetailConstants.IP4_ADDRESS), null);
-                logger.debug("nic, '{}', gets ip, '{}'", nic, ipAddress);
+                logger.debug("Checking if IP address '{}' can be mapped to NIC '{}'", ipAddress, nic);
                 if (StringUtils.isEmpty(nic)) {
                     throw new InvalidParameterValueException(String.format("NIC ID: '%s' is invalid for IP address mapping", nic));
                 }
@@ -240,7 +240,7 @@ public Map<String, Long> getDataDiskToDiskOfferingList() {
             for (Map<String, String> entry : (Collection<Map<String, String>>)dataDiskToDiskOfferingList.values()) {
                 String disk = entry.get(VmDetailConstants.DISK);
                 String offeringUuid = entry.get(VmDetailConstants.DISK_OFFERING);
-                logger.trace("disk, '{}', gets offering, '{}'", disk, offeringUuid);
+                logger.trace("Checking if offering '{}' can be user on disk '{}'", offeringUuid, disk);
                 if (StringUtils.isAnyEmpty(disk, offeringUuid) || _entityMgr.findByUuid(DiskOffering.class, offeringUuid) == null) {
                     throw new InvalidParameterValueException(String.format("Disk offering ID: %s for disk ID: %s is invalid", offeringUuid, disk));
                 }
diff --git a/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java
@@ -224,7 +224,7 @@ public Map<String, List<String>> getServiceProviders() {
             Iterator<? extends Map<String, String>> iter = servicesCollection.iterator();
             while (iter.hasNext()) {
                 Map<String, String> obj = iter.next();
-                logger.trace("service provider entry specified: ", () -> obj);
+                logger.trace("Service provider entry specified: ", obj);
                 HashMap<String, String> services = (HashMap<String, String>)obj;
                 String service = services.get("service");
                 String provider = services.get("provider");
diff --git a/api/src/main/java/org/apache/cloudstack/api/command/user/backup/ListBackupsCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/user/backup/ListBackupsCmd.java
@@ -148,7 +148,7 @@ public void execute() throws ResourceUnavailableException, InsufficientCapacityE
             Pair<List<Backup>, Integer> result = backupManager.listBackups(this);
             setupResponseBackupList(result.first(), result.second());
         } catch (Exception e) {
-            logger.debug("Exception while listing backups", e);
+            logger.error("Exception while listing backups", e);
             throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, e.getMessage());
         }
     }
diff --git a/api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java
@@ -255,7 +255,7 @@ public void create() {
             }
         } catch (NetworkRuleConflictException ex) {
             String message = "Network rule conflict: ";
-            logger.info( "Network rule conflict: {}", ex.getMessage());
+            logger.error( "Network rule conflict: {}", ex.getMessage());
             logger.trace(message, ex);
             throw new ServerApiException(ApiErrorCode.NETWORK_RULE_CONFLICT_ERROR, ex.getMessage());
         }
diff --git a/api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
@@ -271,7 +271,7 @@ public void create() {
                 setEntityUuid(result.getUuid());
             }
         } catch (NetworkRuleConflictException ex) {
-            logger.trace("Network Rule Conflict: ", ex);
+            logger.error("Network Rule Conflict: ", ex);
             throw new ServerApiException(ApiErrorCode.NETWORK_RULE_CONFLICT_ERROR, ex.getMessage(), ex);
         }
     }
diff --git a/api/src/main/java/org/apache/cloudstack/api/command/user/nat/CreateIpForwardingRuleCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/user/nat/CreateIpForwardingRuleCmd.java
@@ -148,7 +148,7 @@ public void create() {
             setEntityId(rule.getId());
             setEntityUuid(rule.getUuid());
         } catch (NetworkRuleConflictException e) {
-            logger.info("Unable to create static NAT rule due to ", e);
+            logger.error("Unable to create static NAT rule due to ", e);
             throw new ServerApiException(ApiErrorCode.NETWORK_RULE_CONFLICT_ERROR, e.getMessage());
         }
     }
diff --git a/api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkACLListCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkACLListCmd.java
@@ -128,7 +128,7 @@ public long getEntityOwnerId() {
         } else {
             account = CallContext.current().getCallingAccount();
             if (!Account.Type.ADMIN.equals(account.getType())) {
-                logger.warn("Only Root Admin can create global ACLs. Account [{}] cannot create any global ACL.", account);
+                logger.error("Only Root Admin can create global ACLs. {} cannot create any global ACL.", account);
                 throw new PermissionDeniedException("Only Root Admin can create global ACLs.");
             }
 
diff --git a/api/src/main/java/org/apache/cloudstack/api/command/user/network/routing/CreateRoutingFirewallRuleCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/user/network/routing/CreateRoutingFirewallRuleCmd.java
@@ -250,7 +250,7 @@ public void execute() throws ResourceUnavailableException {
             }
             ruleResponse.setResponseName(getCommandName());
         } catch (Exception ex) {
-            logger.error("Got exception when create Routing firewall rules: " + ex);
+            logger.error("Got exception when create Routing firewall rules: ", ex);
         } finally {
             if (!success || rule == null) {
                 routedIpv4Manager.revokeRoutingFirewallRule(getEntityId());
diff --git a/api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
@@ -165,7 +165,7 @@ public void create() throws ResourceAllocationException {
     @Override
     public void execute() {
         VMSnapshot vmSnapshot = _vmSnapshotService.getVMSnapshotById(getVMSnapshotId());
-        logger.info("CreateSnapshotFromVMSnapshotCmd with vm snapshot {} with id {} and snapshot [id: {}, uuid: {}]", vmSnapshot, getVMSnapshotId(), getEntityId(), getEntityUuid());
+        logger.info("CreateSnapshotFromVMSnapshotCmd with {} and snapshot [id: {}, uuid: {}]", vmSnapshot, getEntityId(), getEntityUuid());
         CallContext.current().setEventDetails("Vm Snapshot Id: " + vmSnapshot.getUuid());
         Snapshot snapshot = null;
         try {
diff --git a/api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
@@ -356,10 +356,10 @@ private Long findAccountIdToUse(Account callingAccount) {
         try {
             accountIdToUse = _accountService.finalyzeAccountId(accountName, domainId, projectId, true);
         } catch (InvalidParameterValueException | PermissionDeniedException ex) {
-            logger.debug("An exception occurred while finalizing account id with accountName, domainId and projectId" +
-                  "using callingAccountId={}", callingAccount.getUuid(), ex);
-            logger.warn("Unable to find accountId associated with accountName={} and domainId={} or projectId={}" +
+            logger.error("Unable to find accountId associated with accountName={} and domainId={} or projectId={}" +
                     ", using callingAccountId={}", accountName, domainId, projectId, callingAccount.getUuid());
+            logger.debug("An exception occurred while finalizing account id with accountName, domainId and projectId" +
+                    "using callingAccountId={}", callingAccount.getUuid(), ex);
         }
         return accountIdToUse != null ? accountIdToUse : callingAccount.getAccountId();
     }
diff --git a/api/src/main/java/org/apache/cloudstack/api/command/user/vm/BaseDeployVMCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/user/vm/BaseDeployVMCmd.java
@@ -416,9 +416,7 @@ public Map<Integer, Long> getVmNetworkMap() {
                     nic = null;
                 }
                 String networkUuid = entry.get(VmDetailConstants.NETWORK);
-                if (logger.isTraceEnabled()) {
-                    logger.trace(String.format("nic, '%s', goes on net, '%s'", nic, networkUuid));
-                }
+                logger.trace("Checking if NIC '{}' can be mapped on network '{}'", nic, networkUuid);
                 if (nic == null || StringUtils.isEmpty(networkUuid) || _entityMgr.findByUuid(Network.class, networkUuid) == null) {
                     throw new InvalidParameterValueException(String.format("Network ID: %s for NIC ID: %s is invalid", networkUuid, nic));
                 }
diff --git a/api/src/main/java/org/apache/cloudstack/api/command/user/vm/CreateVMFromBackupCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/user/vm/CreateVMFromBackupCmd.java
@@ -137,7 +137,7 @@ public void execute () {
                     message.append(", Please check the affinity groups provided, there may not be sufficient capacity to follow them");
                 }
             }
-            logger.info(String.format("%s: %s", message.toString(), ex.getLocalizedMessage()));
+            logger.info("{}: {}", message.toString(), ex.getLocalizedMessage());
             logger.debug(message.toString(), ex);
             throw new ServerApiException(ApiErrorCode.INSUFFICIENT_CAPACITY_ERROR, message.toString());
         }

Original file line number	Diff line number	Diff line change
`@@ -501,7 +501,7 @@ private void writeDocumentToFile(String newOvfFilePath, Document doc) {`
`501`	`501`	`outfile.write(writer.toString());`
`502`	`502`	`outfile.close();`
`503`	`503`	`} catch (IOException \| TransformerException e) {`
`504`		`- logger.info("Unexpected exception caught while rewriting OVF:{}", e.getMessage(), e);`
	`504`	`+ logger.info("Unexpected exception caught while rewriting OVF: {}", e.getMessage(), e);`
`505`	`505`	`throw new CloudRuntimeException(e);`
`506`	`506`	`}`
`507`	`507`	`}`
`@@ -767,7 +767,7 @@ private Integer getIntValueFromString(String value) {`
`767`	`767`	`try {`
`768`	`768`	`return Integer.parseInt(value);`
`769`	`769`	`} catch (NumberFormatException e) {`
`770`		`- logger.debug("Could not parse the value: {} ignoring it", value);`
	`770`	`+ logger.debug("Could not parse the value: {}, ignoring it", value);`
`771`	`771`	`}`
`772`	`772`	`}`
`773`	`773`	`return null;`
Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ public void execute() {`
`147`	`147`	`this.setResponseObject(hostResponse);`
`148`	`148`	`} catch (Exception e) {`
`149`	`149`	`Host host = _entityMgr.findById(Host.class, getId());`
`150`		`- logger.debug("Failed to update host: {} with id {}", host, getId(), e);`
	`150`	`+ logger.debug("Failed to update {}", host, e);`
`151`	`151`	`throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, String.format("Failed to update host: %s with id %d, %s", host, getId(), e.getMessage()));`
`152`	`152`	`}`
`153`	`153`	`}`
Original file line number	Diff line number	Diff line change
`@@ -237,7 +237,7 @@ public void execute() throws ResourceUnavailableException, ResourceAllocationExc`
`237`	`237`	`logger.warn("Exception: ", ex);`
`238`	`238`	`throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, ex.getMessage());`
`239`	`239`	`} catch (InsufficientCapacityException ex) {`
`240`		`- logger.info(ex);`
	`240`	`+ logger.error(ex);`
`241`	`241`	`throw new ServerApiException(ApiErrorCode.INSUFFICIENT_CAPACITY_ERROR, ex.getMessage());`
`242`	`242`	`}`
`243`	`243`	`}`
Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ public void execute() throws ResourceUnavailableException, InsufficientCapacityE`
`148`	`148`	`Pair<List<Backup>, Integer> result = backupManager.listBackups(this);`
`149`	`149`	`setupResponseBackupList(result.first(), result.second());`
`150`	`150`	`} catch (Exception e) {`
`151`		`- logger.debug("Exception while listing backups", e);`
	`151`	`+ logger.error("Exception while listing backups", e);`
`152`	`152`	`throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, e.getMessage());`
`153`	`153`	`}`
`154`	`154`	`}`
Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,7 @@ public void create() {`
`255`	`255`	`}`
`256`	`256`	`} catch (NetworkRuleConflictException ex) {`
`257`	`257`	`String message = "Network rule conflict: ";`
`258`		`- logger.info( "Network rule conflict: {}", ex.getMessage());`
	`258`	`+ logger.error( "Network rule conflict: {}", ex.getMessage());`
`259`	`259`	`logger.trace(message, ex);`
`260`	`260`	`throw new ServerApiException(ApiErrorCode.NETWORK_RULE_CONFLICT_ERROR, ex.getMessage());`
`261`	`261`	`}`
Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,7 @@ public void create() {`
`271`	`271`	`setEntityUuid(result.getUuid());`
`272`	`272`	`}`
`273`	`273`	`} catch (NetworkRuleConflictException ex) {`
`274`		`- logger.trace("Network Rule Conflict: ", ex);`
	`274`	`+ logger.error("Network Rule Conflict: ", ex);`
`275`	`275`	`throw new ServerApiException(ApiErrorCode.NETWORK_RULE_CONFLICT_ERROR, ex.getMessage(), ex);`
`276`	`276`	`}`
`277`	`277`	`}`
Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ public void create() {`
`148`	`148`	`setEntityId(rule.getId());`
`149`	`149`	`setEntityUuid(rule.getUuid());`
`150`	`150`	`} catch (NetworkRuleConflictException e) {`
`151`		`- logger.info("Unable to create static NAT rule due to ", e);`
	`151`	`+ logger.error("Unable to create static NAT rule due to ", e);`
`152`	`152`	`throw new ServerApiException(ApiErrorCode.NETWORK_RULE_CONFLICT_ERROR, e.getMessage());`
`153`	`153`	`}`
`154`	`154`	`}`
Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ public long getEntityOwnerId() {`
`128`	`128`	`} else {`
`129`	`129`	`account = CallContext.current().getCallingAccount();`
`130`	`130`	`if (!Account.Type.ADMIN.equals(account.getType())) {`
`131`		`- logger.warn("Only Root Admin can create global ACLs. Account [{}] cannot create any global ACL.", account);`
	`131`	`+ logger.error("Only Root Admin can create global ACLs. {} cannot create any global ACL.", account);`
`132`	`132`	`throw new PermissionDeniedException("Only Root Admin can create global ACLs.");`
`133`	`133`	`}`
`134`	`134`